Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure peak detection works with negative signals #84

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

smoia
Copy link
Member

@smoia smoia commented Oct 9, 2024

Closes #

Proposed Changes

Change Type

  • bugfix (+0.0.1)
  • minor (+0.1.0)
  • major (+1.0.0)
  • refactoring (no version update)
  • test (no version update)
  • infrastructure (no version update)
  • documentation (no version update)
  • other

Checklist before review

  • I added everything I wanted to add to this PR.
  • [Code or tests only] I wrote/updated the necessary docstrings.
  • [Code or tests only] I ran and passed tests locally.
  • [Documentation only] I built the docs locally.
  • My contribution is harmonious with the rest of the code: I'm not introducing repetitions.
  • My code respects the adopted style, especially linting conventions.
  • The title of this PR is explanatory on its own, enough to be understood as part of a changelog.
  • I added or indicated the right labels.
  • I added information regarding the timeline of completion for this PR.
  • Please, comment on my PR while it's a draft and give me feedback on the development!

@smoia smoia added the BugFIX This PR generally closes a "Bug" issue, and increments the patch version (0.0.+1) label Oct 9, 2024
@smoia smoia merged commit 1acd337 into physiopy:master Oct 9, 2024
3 checks passed
@smoia smoia deleted the fix/negsignal branch October 9, 2024 10:29
@smoia
Copy link
Member Author

smoia commented Oct 9, 2024

🚀 PR was released in 0.5.2 🚀

@smoia smoia added the released This issue/pull request has been released label Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BugFIX This PR generally closes a "Bug" issue, and increments the patch version (0.0.+1) released This issue/pull request has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant