This repository has been archived by the owner on May 16, 2023. It is now read-only.
Refactoring kata #10
Draft
Refactoring kata #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This class will end up holding on to our derivation list
that the Prover can start to collaborate with. We'll start moving _some_ of the existing prover state over to this object over the next several commits.
We want to replace this line with a call to the new derivations object. This is the API we'll need it to implement.
currently a no-op, just to ensure that we can get the intended signature to typecheck.
Still no-ops, but ensures the call site typechecks.
as we'll need to start holding state in this class
We want to remove the intermediate `derivations` array, so will need to return it from our new class.
We want to move towards the Derivations class managing this evidence, so will need to ensure it has a copy.
to ensure it typechecks
This is the same call we replaced with our extracted method earlier
All reads now factor through `this.derivations` instead.
Similarly, this is an exact copy-paste, except for `this.derivations.` becoming `this.`.
Calls to this are now entirely contained in the `Derivations` class, so we can begin encapsulating them better.
that we will eventually return
again with the natural tweaks for changing context
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This content is merged in, but it was a nice refactor that might be suitable for a class.