Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move reading in REMIND fuel costs to mrtransport #311

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

fbenke-pik
Copy link
Contributor

@fbenke-pik fbenke-pik commented Dec 10, 2024

Purpose of this PR

Remove the warning

WARNING: 
~~~~~ getConfig for option "sourcefolder" must not be used from within readSource! Access will be disabled soon!

Reads in the Remind fuel costs the madrat-way.

See also: pik-piam/mrtransport#28

Checklist:

  • I used ./test-standard-runs to compare and archive the changes introduced by this PR in /p/projects/edget/PRchangeLog/

Further information (optional):

  • Test runs are here: /p/projects/edget/PRchangeLog/20241212_20241212_PR311_RemoveWarnings
  • This should not change any data generated, as the PR just moves around function calls.
  • I made sure that inputdata generation for REMIND (and EDGE-T SA) does not crash using this.

@ahagen-pik
Copy link
Contributor

Hi Falk,
Thank you. I am not familiar with the warning, but have some questions regarding edgeT functionality.

Did you also check if edgeT iterative is still working properly between remind runs? The REMIND fuel costs are also needed in the iterative case, which does to my knowledge not call mrtransport. That's why the functions have been in the edgeTransport package rather than in mrtransport.

Why did you decide to leave the option for an explicitly given gdx path in toolLoadREMINDfuelCosts() although the gdx_path = NULL is hard coded in the function call? I think it would then be more useful to also allow for optionally defining a gdx_path at the very beginning, in the call calcEdgeTransportSA(), similar to how it has been, or get rid of the option altogether.

@ahagen-pik
Copy link
Contributor

Sorry, misunderstanding on my side. Just the readSource for SA is moved to mrtransport and the iterative calculation is left unchanged.

The only thing is that this way we loose the possibility to use different gdx for standalone runs. That option would be quite helpful, for local runs or since we were for example planning to do a sensitivity test at some point. Would it be possible to retain this option without provoking the warning you fixed?

@fbenke-pik
Copy link
Contributor Author

I brought back the option to pass a gdx via calcEdgeTransportSA. Please check again and let me know if this works for you.

@ahagen-pik
Copy link
Contributor

Great. Thank you!

@fbenke-pik fbenke-pik merged commit 8dca393 into pik-piam:master Dec 13, 2024
2 checks passed
@fbenke-pik fbenke-pik deleted the refactor branch December 13, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants