Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid warning by read.report about separator replacement #42

Merged
merged 4 commits into from
Jan 17, 2024
Merged

Avoid warning by read.report about separator replacement #42

merged 4 commits into from
Jan 17, 2024

Conversation

dklein-pik
Copy link
Member

No description provided.

dklein-pik
dklein-pik commented Jan 10, 2024
View reviewed changes
R/readREMIND.R Outdated
}
# remove model and variable name
x <- collapseNames(x)
message("reading fileList")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line will be removed

@dklein-pik dklein-pik marked this pull request as ready for review January 16, 2024 12:51
@codecov Codecov
Copy link

codecov bot commented Jan 16, 2024 •
edited
Loading

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (7cf0b23) 0.02% compared to head (bb31911) 0.02%.

❗ Current head bb31911 differs from pull request most recent head 8da6f09. Consider uploading reports for the commit 8da6f09 to get more accurate results

Files Patch % Lines
R/readREMIND.R 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@          Coverage Diff           @@
##           master     #42   +/-   ##
======================================
  Coverage    0.02%   0.02%           
======================================
  Files         146     146           
  Lines        4737    4737           
======================================
  Hits            1       1           
  Misses       4736    4736

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pfuehrlich-pik
pfuehrlich-pik approved these changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@pfuehrlich-pik pfuehrlich-pik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One last thing: Please require
magclass (>= 6.13.1),
in DESCRIPTION to make sure showSeparatorWarning is available.

@dklein-pik dklein-pik merged commit 8ec033c into pik-piam:master Jan 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pfuehrlich-pik pfuehrlich-pik pfuehrlich-pik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dklein-pik @pfuehrlich-pik