Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for version incement for PRs #472

Closed
wants to merge 4 commits into from
Closed

Check for version incement for PRs #472

wants to merge 4 commits into from

Conversation

fbenke-pik
Copy link
Contributor

No description provided.

@fbenke-pik fbenke-pik changed the title Check Check for version incement for PRs Feb 12, 2024
pascal-sauer
pascal-sauer reviewed Feb 12, 2024
View reviewed changes
Copy link

@pascal-sauer pascal-sauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On second thought, setting up the whole dependencies again just to run a tiny command seems wasteful. Could we integrate this into our main github action, and only run it if the action was triggered by a PR (and not a push)?

@fbenke-pik fbenke-pik closed this Feb 13, 2024
@fbenke-pik fbenke-pik deleted the check branch February 13, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascal-sauer pascal-sauer pascal-sauer left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fbenke-pik @pascal-sauer