added emissions and emission factors for SSP3 #603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LaviniaBaumstark
approved these changes
Dec 4, 2024
merfort
reviewed
Dec 4, 2024
| emi[r_HMStrong, 2050, "SSP3"] <- pmin(setYears(emi[r_HMStrong, 2030, "SSP3"]), | ||
| setYears(emissions_exogenous[r_HMStrong, 2030, "CLE"])) # 2050: CLE30 | ||
| emi[r_HMStrong, 2100, "SSP3"] <- pmin(setYears(emi[r_HMStrong, 2050, "SSP3"]), | ||
| setYears(emissions_exogenous[r_HMStrong, 2030, "CLE"] )) # 2100: Lowest CLE30 or lower -> 0.8*CLE30 |
There was a problem hiding this comment.
Suggested change
| setYears(emissions_exogenous[r_HMStrong, 2030, "CLE"] )) # 2100: Lowest CLE30 or lower -> 0.8*CLE30 | |
| setYears(emissions_exogenous[r_HMStrong, 2030, "CLE"] )) # 2100: Lowest CLE30 or lower |
I don't know, why in the SSP2 case there was this reduction to 80%, but here it was deliberately removed, right?
There was a problem hiding this comment.
(so it should be removed from the comment as well)
merfort
reviewed
Dec 4, 2024
| emi[r_HMRest, 2050, "SSP3"] <- pmin(setYears(emi[r_HMRest, 2030, "SSP3"]), | ||
| setYears(emissions_exogenous[r_HMRest, 2030, "CLE"])) # 2050: Min CLE30 -> CLE30 | ||
| emi[r_HMRest, 2100, "SSP3"] <- pmin(setYears(emi[r_HMRest, 2050, "SSP3"]), | ||
| setYears(emissions_exogenous[r_HMRest, 2030, "CLE"] )) # 2100: CLE30 WEU -> 0.8*CLE30 |
There was a problem hiding this comment.
Suggested change
| setYears(emissions_exogenous[r_HMRest, 2030, "CLE"] )) # 2100: CLE30 WEU -> 0.8*CLE30 | |
| setYears(emissions_exogenous[r_HMRest, 2030, "CLE"] )) # 2100: CLE30 WEU |
merfort
reviewed
Dec 4, 2024
| emi[r_L, 2050, "SSP3"] <- pmin(setYears(emi[r_L, 2030, "SSP3"]), | ||
| setYears(emissions_exogenous[r_L, 2030, "CLE"])) # 2050: Min CLE30 -> CLE30 | ||
| emi[r_L, 2100, "SSP3"] <- pmin(setYears(emi[r_L, 2050, "SSP3"]), | ||
| setYears(emissions_exogenous[r_L, 2030, "CLE"] )) # 2100: CLE30 WEU -> 0.95*CLE30 |
There was a problem hiding this comment.
Suggested change
| setYears(emissions_exogenous[r_L, 2030, "CLE"] )) # 2100: CLE30 WEU -> 0.95*CLE30 | |
| setYears(emissions_exogenous[r_L, 2030, "CLE"] )) # 2100: CLE30 WEU |
|
I also do not know why that change was introduced and hardcoded. I guess this was Sebastian. I did not follow the log backwards. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the implementation of the SSP3 emissions and emission factors (copy-paste of SSP2) and set everything to CLE (Current Legislation) in all regions and all times.