remove dependency to mrremind functions #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbenke-pik
changed the title
ahagen-pik
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
This PR removes the dependency on
mrremind::calcIOat the cost of introducing a minor redundancy. In consequence,toolIEAharmonizationdependencies are reduced by half (from 189 to 93 dependencies). Cache recalculation based on irrelevant changes incalcIOand the numerous madrat functions it depends on becomes less frequent, resulting in less unnecessary, time-consuming cache recalculations downstream as well.Besides, the circular dependency between mrremind and the transport packages should be resolved by this (i.e. the transport packages no longer depend on mrremind).
Related PR in mrremind: pik-piam/mrremind#598
Checklist:
I used ./test-standard-runs to compare and archive the changes introduced by this PR in /p/projects/edget/PRchangeLog/
Test runs are here: `/p/projects/edget/PRchangeLog/20241126_20241121_Moved_Functions/