Merge pull request #1339 from msimberg/sanitizers-release-builds

Add `RelWithDebInfo` mode sanitizer CI workflows
pika-org · Nov 22, 2024 · bb3d37a · bb3d37a
2 parents 6b8e58b + edbb073
commit bb3d37a
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 2 deletions.
diff --git a/.github/workflows/linux_asan_ubsan_lsan.yml b/.github/workflows/linux_asan_ubsan_lsan.yml
@@ -25,6 +25,10 @@ jobs:
       # --privileged is enabled for sysctl further down.
       options: --privileged
 
+    strategy:
+      matrix:
+        build_type: ["Debug", "RelWithDebInfo"]
+
     steps:
       - uses: actions/checkout@v4
       - name: Update apt repositories for ccache
@@ -42,7 +46,7 @@ jobs:
                 -Bbuild \
                 -GNinja \
                 -DCMAKE_CXX_COMPILER_LAUNCHER=ccache \
-                -DCMAKE_BUILD_TYPE=Debug \
+                -DCMAKE_BUILD_TYPE= ${{ matrix.build_type }} \
                 -DPIKA_WITH_MALLOC=system \
                 -DPIKA_WITH_MPI=OFF \
                 -DPIKA_WITH_EXAMPLES=ON \

diff --git a/.github/workflows/linux_tsan.yml b/.github/workflows/linux_tsan.yml
@@ -25,6 +25,10 @@ jobs:
       # --privileged is enabled for sysctl further down.
       options: --privileged
 
+    strategy:
+      matrix:
+        build_type: ["Debug", "RelWithDebInfo"]
+
     steps:
       - uses: actions/checkout@v4
       - name: Update apt repositories for ccache
@@ -49,7 +53,7 @@ jobs:
                 -Bbuild \
                 -GNinja \
                 -DCMAKE_CXX_COMPILER_LAUNCHER=ccache \
-                -DCMAKE_BUILD_TYPE=Debug \
+                -DCMAKE_BUILD_TYPE=${{ matrix.build_type }} \
                 -DPIKA_WITH_MALLOC=system \
                 -DPIKA_WITH_MPI=OFF \
                 -DPIKA_WITH_EXAMPLES=ON \

diff --git a/libs/pika/schedulers/include/pika/schedulers/queue_holder_thread.hpp b/libs/pika/schedulers/include/pika/schedulers/queue_holder_thread.hpp
@@ -475,6 +475,8 @@ namespace pika::threads::detail {
                     debug::detail::threadinfo<threads::detail::thread_id_ref_type*>(&tid));
             }
             else
+#else
+            PIKA_UNUSED(heap);
 #endif
             {
                 // Allocate a new thread object.

diff --git a/libs/pika/schedulers/include/pika/schedulers/thread_queue.hpp b/libs/pika/schedulers/include/pika/schedulers/thread_queue.hpp
@@ -164,6 +164,8 @@ namespace pika::threads::detail {
                 threads::detail::get_thread_id_data(thrd)->rebind(data);
             }
             else
+# else
+            PIKA_UNUSED(heap);
 # endif
 #endif
             {