Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test mpi_ring_async_sender_receiver with all MPI completion modes #1151

Merged
merged 11 commits into from
Jul 2, 2024
Merged

Test mpi_ring_async_sender_receiver with all MPI completion modes #1151

merged 11 commits into from
Jul 2, 2024

Commits on Jun 25, 2024

  1. Add --pika:mpi-completion-mode command line option to set the complet… 

    …ion mode
    @msimberg
    msimberg committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    f5996b0 View commit details
    Browse the repository at this point in the history

  2. Test all MPI completion modes with mpi_ring_async_sender_receiver test

    @msimberg
    msimberg committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    ab64fd6 View commit details
    Browse the repository at this point in the history

  3. Use PIKA_TEST_EQ instead of PIKA_ASSERT for test check in mpi_ring_as… 

    …ync_sender_receiver test
    @msimberg
    msimberg committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    cacc596 View commit details
    Browse the repository at this point in the history

  4. Call enable_optimizations only once in mpi_ring_async_sender_receiver… 

    … test
    @msimberg
    msimberg committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    e5ba863 View commit details
    Browse the repository at this point in the history

  5. Replace manual yield-while loop with yield_while call

    @msimberg
    msimberg committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    761e4ae View commit details
    Browse the repository at this point in the history

  6. Remove unused call_mpi_irecv function from mpi_ring_async_sender_rece… 

    …iver test
    @msimberg
    msimberg committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    06d0c07 View commit details
    Browse the repository at this point in the history

  7. Decrement internal MPI counters before calling continuation

    @msimberg
    msimberg committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    18b4f76 View commit details
    Browse the repository at this point in the history

  8. Release condition variable lock before triggering continuation in MPI… 

    … suspend_resume mode
    @msimberg
    msimberg committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    c8ec9cb View commit details
    Browse the repository at this point in the history

  9. Relax OpenMPI valgrind memcheck suppression

    @msimberg
    msimberg committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    5d4242b View commit details
    Browse the repository at this point in the history

  10. Reduce counters and fix race condition in counter check 

    Two counters were used for debugging during development, but are not
really needed for counting tasks in flight and it's better to use the
main in_flight counter for checking when finished.
    @biddisco @msimberg
    biddisco authored and msimberg committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    13e41fe View commit details
    Browse the repository at this point in the history

  11. Make MPI polling max size atomic 

    This avoids data races between writing (set_max_polling_size) and reading (within the MPI polling
loop) the max polling size. Reads are relaxed since we don't care much about stale values being
used.
    @msimberg
    msimberg committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    61555e4 View commit details
    Browse the repository at this point in the history