Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable LTO in CircleCI configuration #1156

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Conversation

msimberg
Copy link
Contributor

No description provided.

@msimberg msimberg added this to the 0.26.0 milestone Jun 10, 2024
@msimberg msimberg self-assigned this Jun 10, 2024
Copy link
Contributor

@aurianer aurianer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@aurianer aurianer enabled auto-merge June 10, 2024 20:53
@aurianer aurianer disabled auto-merge June 10, 2024 20:53
@aurianer
Copy link
Contributor

Should we actually enable this in pika itself?

@msimberg
Copy link
Contributor Author

I'd like to try it out a bit more broadly first (e.g. in DLA-Future and in other configurations), but yeah, assuming it doesn't break anything it sounds like a good idea to enable it by default! This PR was mostly to see if it actually breaks anything as a first step. I opened #1163 as a follow up. I suppose a next step would be trying to enable it on all CI configurations. I do believe it has to be overridable to disable in case of future issues, but as long as that's possible I don't see why we couldn't enable it by default. In spack we could also consider simply adding an lto variant (or should that be handled with cxxflags, not sure...).

@msimberg
Copy link
Contributor Author

Since this only affects the CircleCI configuration (which is currently working) I'm going to go ahead and merge this.

@msimberg msimberg merged commit 1466a0f into pika-org:main Jun 14, 2024
36 of 38 checks passed
@msimberg msimberg deleted the lto-ci branch June 14, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Archive
Development

Successfully merging this pull request may close these issues.

2 participants