Add clang 19 CI configuration #1283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
msimberg
force-pushed
the
clang-19-ci
branch
3 times, most recently
from
becfd1f
to
a1bd16d
Compare
msimberg
force-pushed
the
clang-19-ci
branch
2 times, most recently
from
c5b574a
to
2a439ba
Compare
msimberg
commented
Oct 31, 2024
Starting with clang 19, the unused member functions cas that take a deque_anchor fail to compile because they attempt to call load directly on the deque_anchor type, whereas they should be calling load on the atomic stored in the deque_anchor. Neither GCC nor clang until version 18 failed to compile the broken member functions (because they were unused they were never instantiatied). Since the functions are unused, simply remove them. Related llvm issue: llvm/llvm-project#102177.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also enables libc++'s hardening mode (https://libcxx.llvm.org/Hardening.html).
I've initially enabled the strongest mode (
_LIBCPP_HARDENING_MODE_DEBUG) but what checks are actually enabled seems to depend on the actual ABI used to compile libc++, so I don't know if all checks are actually enabled.clang 19 warns about
aligned_storage_tbeing deprecated, so this requires #1280.clang 19 also diagnoses member functions that can't be instantiated, even if they're unused.
deque_anchorhad a few unused functions that could not be instantiated, but according to the standard they're allowed to not be instantiated. clang 19 diagnoses these even when unused leading to compilaton failures. This PR removes the unused member functions. A similar issue is llvm/llvm-project#102177. llvm/llvm-project#102177 gives a bit more motivation for the change. Supposedly GCC 15 will make the same change, so sooner or later we would be bitten by this anyway, and it's nice to have this diagnosed.Fixes #1300.