-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pre-commit to use CI base image #1307
Update pre-commit to use CI base image #1307
Conversation
d817943
to
5855103
Compare
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments, looks good to me otherwise.
@biddisco might want to have a look as well since I think he's also using the pre-commit hook. If there's a preference for either we can also consider having both the old and the new version as alternatives (though only option is better of course).
5855103
to
a5d72bb
Compare
a5d72bb
to
d331450
Compare
This is horrific - why would you require podman to be run to use a commit hook? |
Please try to be a bit more respectful next time.
It's explained quite clearly in the PR description. If you have more specific questions, please do ask. |
Revert #1307 but keep podman-based pre-commit hook in pre-commit-podman
The previous pre-commit script supposed that we had clang-format and cmake-format installed on the system. It also supposed that we update it each time we decide to upgrade the versions.
This PR is using the docker image used in CI, pulls it if it's not available locally. The requirement here is podman, but the user can also remove podman from the pre-commit script if he prefers, the simplified commands run within podman can be run locally