-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand and add more CUDA/HIP documentation #1309
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
libs/pika/async_cuda_base/include/pika/async_cuda_base/cublas_handle.hpp
Show resolved
Hide resolved
libs/pika/async_cuda/include/pika/async_cuda/then_with_stream.hpp
Outdated
Show resolved
Hide resolved
libs/pika/async_cuda_base/include/pika/async_cuda_base/cuda_stream.hpp
Outdated
Show resolved
Hide resolved
37b7898
to
afec1e1
Compare
I welcome more feedback on this PR now. I feel like some of the examples I've created are a bit forced/artificial in the name of showing off what's possible with the adaptors, so if you have suggestions on how to improve change them that's particularly welcome. I've also now documented the types of the CUDA/HIP sender adaptors so that we can document the parameters of them. I think it looks decent enough, but interested in hearing feedback from others. |
libs/pika/async_cuda/include/pika/async_cuda/then_with_stream.hpp
Outdated
Show resolved
Hide resolved
libs/pika/async_cuda_base/include/pika/async_cuda_base/cublas_handle.hpp
Outdated
Show resolved
Hide resolved
libs/pika/async_cuda_base/include/pika/async_cuda_base/cusolver_handle.hpp
Outdated
Show resolved
Hide resolved
libs/pika/async_cuda/include/pika/async_cuda/then_with_stream.hpp
Outdated
Show resolved
Hide resolved
libs/pika/async_cuda_base/include/pika/async_cuda_base/cuda_stream.hpp
Outdated
Show resolved
Hide resolved
libs/pika/async_cuda_base/include/pika/async_cuda_base/cuda_stream.hpp
Outdated
Show resolved
Hide resolved
75a9371
to
3caadb0
Compare
Document cuda_pool, cuda_scheduler, cuda_stream, cublas_handle, cusolver_handle, as well as expose these with CUDA sender adaptors in the documentation. Adds a high-level example of using CUDA functionality.
… member functions in cuda_schewduler
Adds documentation for classes that weren't yet documented and updates the existing documentation. Adds a section for
pika/cuda.hpp
to the API documentation.Early stages, far from complete, but may require some discussion before continuing.