Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid stack overflow in task_size bulk test #1332

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

msimberg
Copy link
Contributor

stdexec in debug mode is particularly prone to triggering a stack overflow, but pika's std::execution implementation can trigger it as well. Compiling with optimizations also simply delays the stack overflow. This should fix the frequent failures on the performance tests in CI.

@msimberg msimberg added this to the 0.31.0 milestone Nov 15, 2024
@msimberg msimberg self-assigned this Nov 15, 2024
Copy link

codacy-production bot commented Nov 15, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.04% (target: -1.00%) (target: 90.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (b207b3f) 18274 13810 75.57%
Head commit (1411c10) 18274 (+0) 13803 (-7) 75.53% (-0.04%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1332) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@msimberg msimberg force-pushed the task-size-bulk-stack-overflow branch from f845306 to c534201 Compare November 19, 2024 08:06
stdexec in debug mode is particularly prone to triggering a stack overflow, but pika's
std::execution implementation can trigger it as well. Compiling with optimizations also simply
delays the stack overflow.
@msimberg msimberg force-pushed the task-size-bulk-stack-overflow branch from c534201 to 1411c10 Compare November 19, 2024 12:26
@msimberg msimberg added this pull request to the merge queue Nov 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 19, 2024
@msimberg msimberg added this pull request to the merge queue Nov 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 19, 2024
@msimberg msimberg merged commit df862d7 into pika-org:main Nov 19, 2024
37 checks passed
@msimberg msimberg deleted the task-size-bulk-stack-overflow branch November 19, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants