Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reapply #1295 #1337

Merged
merged 4 commits into from
Nov 21, 2024
Merged

Reapply #1295 #1337

merged 4 commits into from
Nov 21, 2024

Conversation

msimberg
Copy link
Contributor

@msimberg msimberg commented Nov 19, 2024

After reverting #1295 in #1334, this reapplies the original PR with a fix for let_value. The issue was accessing the wrong callable f inside set_value for let_value. I was still accessing the f from this, even though this had already been moved (and thus emptied) into a local variable. This also adds a unit test that triggers the issue before the fix.

bulk and when_all had similar issues which have also been fixed.

@msimberg msimberg added this to the 0.31.0 milestone Nov 19, 2024
@msimberg msimberg self-assigned this Nov 19, 2024
Copy link

codacy-production bot commented Nov 19, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.01% (target: -1.00%) 95.59% (target: 90.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (b207b3f) 18274 13810 75.57%
Head commit (c64991c) 18297 (+23) 13829 (+19) 75.58% (+0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1337) 68 65 95.59%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Moving from this results in an empty f, since this has already been moved to the local copy of the
receiver r.
@msimberg msimberg marked this pull request as ready for review November 19, 2024 12:16
@msimberg msimberg merged commit 4c44300 into pika-org:main Nov 21, 2024
36 of 37 checks passed
@msimberg msimberg deleted the unrevert-set-value-member branch November 21, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

1 participant