-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for async_rw_mutex
#1356
base: main
Are you sure you want to change the base?
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
libs/pika/synchronization/include/pika/synchronization/async_rw_mutex.hpp
Outdated
Show resolved
Hide resolved
cd89684
to
66173a7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a curiosity, but for the rest thanks for the nice documentation!
// Start and wait for all the work to finish. | ||
tt::sync_wait(ex::when_all(std::move(rw_access1), std::move(ro_access1), | ||
std::move(ro_access2), std::move(ro_access3), | ||
std::move(rw_access2))); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: in principle, given that DAG, can we sync_wait
just the last readwrite access?
My doubt is this one. They do not depend on each other as sender, but the mutex implicitly creates a dependency. This "difference" (if it is a difference, or is it just conceptual?) requires that we start each sender independently, or we can just sync_wait
the last one and all the chain is started as if they were actually dependent?
Part of #49.
Will likely conflict with #1355, so let's get that in first.