-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to set a CMAKE_CUDA_STANDARD
different from CMAKE_CXX_STANDARD
#700
base: main
Are you sure you want to change the base?
Conversation
bors try |
tryBuild failed: |
CMAKE_CUDA_STANDARD
different from CMAKE_CXX_STANDARD
bors try |
tryBuild failed: |
bors try |
tryBuild failed: |
bors try |
tryBuild failed: |
f4bc291
to
42fc27c
Compare
bors try |
tryBuild failed: |
Looks good now :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @aurianer for looking into this! I think we should test this with +stdexec
since that is the use case for this and I think enabling that will break in CI. Could explore a bit how this fails with stdexec enabled so that we can see how to tackle this best? In particular I'm worried about the feature tests being insufficient if we start allowing different standard versions.
This PR is in general lower priority until we've tested the CPU-only configurations in DLA-Future though.
gcc_version="9.3.0" | ||
boost_version="1.75.0" | ||
hwloc_version="2.0.3" | ||
cuda_version="11.2.0" | ||
fmt_version="9.1.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What was the problem with 10.0.0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. During compilation of which file does that happen?
We definitely have that covered here:
pika/libs/pika/logging/include/pika/logging/level.hpp
Lines 61 to 69 in 41b4abb
template <> | |
struct fmt::formatter<pika::util::logging::level> : fmt::formatter<std::string> | |
{ | |
template <typename FormatContext> | |
auto format(pika::util::logging::level const& value, FormatContext& ctx) | |
{ | |
return fmt::formatter<std::string>::format(pika::util::logging::levelname(value), ctx); | |
} | |
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many of the cuda files, the error I pasted is for cuda_sender_test
though, will try to add the GPU stdexec and then see what's happening
42fc27c
to
c390d33
Compare
SonarCloud Quality Gate failed. 0 Bugs No Coverage information Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
c390d33
to
021b605
Compare
# file LICENSE_1_0.txt or copy at http://www.boost.org/LICENSE_1_0.txt) | ||
|
||
configuration_slurm_constraint="gpu" | ||
configuration_skip_pr="true" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might want to set
configuration_skip_pr="true" | |
configuration_skip_pr="false" |
for now if you want to test this in CI. In this case it may be easier to just test it manually though.
021b605
to
54d4f04
Compare
will look at the failures in a separate PR
54d4f04
to
1f95f41
Compare
@aurianer should we abandon this now that we've got DLA-Future compiling with C++20? |
Fixes #699
Note: Looks like there are problems with fmt@10, will look into it in a separate PR.