redesign application ui

[icai]

redesign application ui

[pilot51]

Thanks for the contribution and especially the new translation!

This is by far the largest PR ever for Voice Notify and it may take some time before I'm comfortable merging it in. I'm also asking the community what they think of the redesign, which may have an impact on what changes I allow.

There are a number of issues below that I would like you to resolve before I will approve, as well as some nitpicks that aren't necessary for approval.

To help me and the community better understand the changes, please edit the PR description with a summary of changes and include screenshots of the redesigns.

Also please set your formatter to use tab indentation for this project so it is consistent. Regardless of your preference, I think we can agree there's nothing worse than mixed indentation.

[pilot51]

This is harder to read in the dark theme than the previous primary color (0xFF1CB7D5). I suggest using separate colors for each theme, preferably keeping the previous colors which I chose based on the icon to stick with a common theme.

[icai]

make it like android 14 systemui

[pilot51]

The screenshot below is what I'm talking about for both color issues.
In this case, ClearBlue is being used for the button text color, which does not have good contrast and can be especially hard to read in certain lighting conditions.

[icai]

I will change to dialog background and rewrite the design.

[pilot51]

The text replace dialog uses secondary for the description and this color makes it hard to read.

[pilot51]

It may be a good idea to create a separate PR for just the translation. That should be quick to push through. The redesign is holding it back.

[pilot51]

Build error: This breaks PreferenceDialogs.rememberTimePickerState() because TimePickerState.Saver() was removed in beta02. I suggest reverting to beta01 and I'll handle the migration.

[pilot51]

I find that the Ignore None switch is confusing. It would be less confusing to call it "Enable All", but I think it would be more intuitive to keep ignore all/none as separate actions, as it was originally, so it can double as a "reset all to default". If we use a switch, I think it should reflect appDefaultEnable. One thing that was missing from the original design was an indication of what the default is.

Suggestions:

1. Go back to the old way, with Ignore All and Ignore None options.
2. Change the switch to "Enable by Default" and have it only toggle appDefaultEnable without toggling any apps. Add the separate Ignore All and Ignore None options. Changing the default won't need the confirmation, but the bulk actions will.
3. Change the switch to "Enable by Default" and show a confirmation dialog that provides options to reset all apps to the new default, only change the default, or cancel.

On another note, I was waiting for all my concerns with this PR to be resolved so I could include it in v1.4.0. Unfortunately that's holding things up more than I had anticipated, so for now I'll plan on getting this in v1.5.0. That includes the translation unless you split that into another PR or add it through Weblate.

[icai]

@pilot51 AI translation should be faster. Copy the default Value string.xml file, prompt:{content} translate all value to chinese, keep the order, return all of the content. And the Suggestions I will review again.
.

[pilot51]

I tried using AI translations once and someone who knew the language that I translated to told me to never do that again.
Often the translations don't come out right because it doesn't understand the context.
Since I am personally unable to verify a translation because I am not familiar with the language, I will not be using AI translation.
I don't care if contributing translators use AI, but I have to trust that they understand the language and proofread it.