Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Request::get with explicit input sources #773

Closed
wants to merge 1 commit into from
Closed

Replace Request::get with explicit input sources #773

wants to merge 1 commit into from

Conversation

kingjia90
Copy link
Contributor

Resolves #771

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
6 New Major Issues (required ≤ 0)
D Maintainability Rating on New Code (required ≥ A)
40 New Critical Issues (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@fashxp
Copy link
Member

fashxp commented Dec 10, 2024

won't do that for classic ui bundle anymore.

@fashxp fashxp closed this Dec 10, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Dec 10, 2024
@kingjia90 kingjia90 deleted the replace-request-input branch December 10, 2024 08:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace Request::get with explicit input sources
2 participants
@kingjia90 @fashxp