-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add add all definitions button and multi drag and drop #871
Add add all definitions button and multi drag and drop #871
Conversation
Ouh sry I forgot to commit on 08.08 I'm back from vacation then I'll take care of it |
First of all, thank you for your PR! The functionality in the video looks really handy. One minor thing for your PR though. You do not need to change all the translation files. The English version is enough. Thank you in advance! |
c745c4c
to
cadc2ff
Compare
Quality Gate passedIssues Measures |
Good morning @mattamon , All right, thanks for the feedback :) Greetings Naoh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just tested it and it works like a charm!
It is a really cool feature! I like it a lot!
https://github.com/pimcore/data-hub/blob/1.x/doc/01_Installation_and_Upgrade/01_Upgrade_Notes.md -> would you mind, adding it to the upgrade notes to 1.8? I think we should mention this specifically :)
Some thoughts maybe. The itemclick
handler could be its own function.
https://github.com/pimcore/data-hub/pull/871/files#diff-dbabce29090ce7119c18917a183b4fb8d7bb2eaacb6b287ff321efa2ecbd1645R520-R550 -> maybe this if else construct could be a bit simplified.
My thougths can also be done in a separate PR of course.
Hi, thanks for the feedback, Regards Noah |
Thank you Noah! Appreciate the effort you are putting in! |
@noahcommandeur-twocream just saw this PR - fantastic idea to add this button. Are there any updates? I would love to put it into today's release 👨🚀 🚀 |
Unfortunately I haven't quite got around to it yet, but I'll manage it in the next few days, maybe even today in the course of the day... |
@noahcommandeur-twocream sure. You can also create a follow-up PR. 👨🚀 🚀 |
Well then I will add a code cleanup as a follow up :) I have opened a PR for the changes to the upgrade notes. |
@noahcommandeur-twocream Thanks for the quick reply - now this PR can be part of the 1.8 release 💯 🥇 |
Changes in this pull request
Added a button that adds all definitions except for the system columns.
Furthermore, multi drag and drop has been added with STR + click you can select several fields and drag them over to the configuration.
You can deselect multiple fields and remove them from the configuration again
Button for delete complete configuration fixed
And category selector added ( STR + click ) on a category
Additional info
Umsetzung.DataHub.mp4