Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add add all definitions button and multi drag and drop #871

Conversation

noahcommandeur-twocream
Copy link
Contributor

Changes in this pull request

Added a button that adds all definitions except for the system columns.
Furthermore, multi drag and drop has been added with STR + click you can select several fields and drag them over to the configuration.

You can deselect multiple fields and remove them from the configuration again

Button for delete complete configuration fixed

And category selector added ( STR + click ) on a category

Additional info

Umsetzung.DataHub.mp4

@Nxooah
Copy link
Contributor

Nxooah commented Jul 29, 2024

Ouh sry I forgot to commit on 08.08 I'm back from vacation then I'll take care of it

@mattamon
Copy link
Contributor

Hey @noahcommandeur-twocream,

First of all, thank you for your PR! The functionality in the video looks really handy.

One minor thing for your PR though. You do not need to change all the translation files. The English version is enough.
The translation get synced to POEditor https://poeditor.com/ get translated there and we get the translations back as a PR.
Could you please remove all the other translations? :)

Thank you in advance!

@noahcommandeur-twocream noahcommandeur-twocream force-pushed the add-all-definitions-button-to-datahub-scheme branch from c745c4c to cadc2ff Compare August 16, 2024 07:10
Copy link

@noahcommandeur-twocream
Copy link
Contributor Author

Good morning @mattamon ,

All right, thanks for the feedback :)
In the future I will know that I only have to take care of the English translation
Is adapted!

Greetings Naoh

@CLAassistant
Copy link

CLAassistant commented Aug 28, 2024

CLA assistant check
All committers have signed the CLA.

@mattamon mattamon added this to the 1.8.0 milestone Sep 2, 2024
Copy link
Contributor

@mattamon mattamon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@noahcommandeur-twocream

I just tested it and it works like a charm!
It is a really cool feature! I like it a lot!

https://github.com/pimcore/data-hub/blob/1.x/doc/01_Installation_and_Upgrade/01_Upgrade_Notes.md -> would you mind, adding it to the upgrade notes to 1.8? I think we should mention this specifically :)

Some thoughts maybe. The itemclick handler could be its own function.
https://github.com/pimcore/data-hub/pull/871/files#diff-dbabce29090ce7119c18917a183b4fb8d7bb2eaacb6b287ff321efa2ecbd1645R520-R550 -> maybe this if else construct could be a bit simplified.
My thougths can also be done in a separate PR of course.

@noahcommandeur-twocream
Copy link
Contributor Author

Hi, thanks for the feedback,
I'll take another look at the item click function and optimize it, then I'll expand the upgrade notes :)

Regards Noah

@mattamon
Copy link
Contributor

mattamon commented Sep 2, 2024

Hi, thanks for the feedback, I'll take another look at the item click function and optimize it, then I'll expand the upgrade notes :)

Regards Noah

Thank you Noah! Appreciate the effort you are putting in!

@Corepex
Copy link
Contributor

Corepex commented Sep 18, 2024

@noahcommandeur-twocream just saw this PR - fantastic idea to add this button.

Are there any updates? I would love to put it into today's release 👨‍🚀 🚀

@Nxooah
Copy link
Contributor

Nxooah commented Sep 18, 2024

Unfortunately I haven't quite got around to it yet, but I'll manage it in the next few days, maybe even today in the course of the day...
otherwise as a FollowUP during the days?

@Corepex
Copy link
Contributor

Corepex commented Sep 18, 2024

otherwise as a FollowUP during the days?

@noahcommandeur-twocream sure. You can also create a follow-up PR.
Do you have a few minutes to tell the world about your improvement in the 1.8 upgrade notes?

👨‍🚀 🚀

@Nxooah
Copy link
Contributor

Nxooah commented Sep 18, 2024

Well then I will add a code cleanup as a follow up :) I have opened a PR for the changes to the upgrade notes.
if you want to refine the text a little more you are welcome to do so :)
#884

@Corepex Corepex merged commit 6dbcc47 into pimcore:1.x Sep 18, 2024
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 18, 2024
@Corepex
Copy link
Contributor

Corepex commented Sep 18, 2024

@noahcommandeur-twocream Thanks for the quick reply - now this PR can be part of the 1.8 release 💯 🥇

@heigpa heigpa linked an issue Sep 25, 2024 that may be closed by this pull request
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement]: Allow all columns of an entity
7 participants