Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CsFeature title #912

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Conversation

dturopoli
Copy link
Contributor

Added title to classification store key graphql output.

Should we also consider admin translations for titles?

Copy link

github-actions bot commented Nov 13, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@dturopoli dturopoli changed the title CSfeature title Added CsFeature title Nov 13, 2024
@dturopoli dturopoli force-pushed the feature/csfeature-title branch from ca5c32c to 9e696cc Compare November 13, 2024 10:54
Copy link

@mcop1 mcop1 self-assigned this Nov 29, 2024
@mcop1 mcop1 changed the base branch from 1.8 to 1.x November 29, 2024 09:51
@mcop1 mcop1 added this to the 1.9.0 milestone Nov 29, 2024
@mcop1
Copy link
Contributor

mcop1 commented Nov 29, 2024

Hello @dturopoli ,

pr looks good to me, thank you. I would like to have it in the next release, so I would merge it right now, that way we provide the basic functionality. Adding admin translations would be nice, but that can still be done in a follow up.

Thanks!

@mcop1 mcop1 merged commit 3669cc6 into pimcore:1.x Nov 29, 2024
9 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants