Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Newly added operators not working anymore #917

Merged
merged 3 commits into from
Nov 29, 2024
Merged

[Bug]: Newly added operators not working anymore #917

merged 3 commits into from
Nov 29, 2024

Conversation

mcop1
Copy link
Contributor

@mcop1 mcop1 commented Nov 26, 2024

Follow up to #871

PR #871 broke operators for new configurations or for newly added operator configuration in the configuration dialog.
This pr aims to readd some of the logic, regarding operators, from before.

@mcop1 mcop1 added the Bug label Nov 26, 2024
@mcop1 mcop1 added this to the 1.8.4 milestone Nov 26, 2024
@mcop1 mcop1 self-assigned this Nov 26, 2024
@mcop1 mcop1 changed the base branch from 1.x to 1.8 November 26, 2024 13:47
@mcop1
Copy link
Contributor Author

mcop1 commented Nov 26, 2024

Hello @noahcommandeur-twocream ,

since you created the pr 871, do you mind to have a look at this pr too, please? Just to check if I missed something obvious.

Thank you!

@mcop1 mcop1 marked this pull request as ready for review November 26, 2024 14:20
@mcop1 mcop1 merged commit 656cfe6 into 1.8 Nov 29, 2024
3 checks passed
@mcop1 mcop1 deleted the fix_operators branch November 29, 2024 07:31
@github-actions github-actions bot locked and limited conversation to collaborators Nov 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant