add small cleanup

pimcore · Oct 22, 2024 · 1ae4909 · 1ae4909
1 parent 82504e1
commit 1ae4909
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/src/IndexService/Worker/OpenSearch/AbstractOpenSearch.php b/src/IndexService/Worker/OpenSearch/AbstractOpenSearch.php
@@ -77,11 +77,11 @@ abstract class AbstractOpenSearch extends ProductCentricBatchProcessingWorker
 
     protected LoggerInterface $logger;
 
-    public function __construct(SearchConfigInterface $tenantConfig, Connection $db, EventDispatcherInterface $eventDispatcher, LoggerInterface $pimcoreEcommerceEsLogger)
+    public function __construct(SearchConfigInterface $tenantConfig, Connection $db, EventDispatcherInterface $eventDispatcher, LoggerInterface $pimcoreEcommerceOsLogger)
     {
         parent::__construct($tenantConfig, $db, $eventDispatcher);
-        $this->logger = $pimcoreEcommerceEsLogger;
-        $this->indexName = ($tenantConfig->getClientConfig('indexName')) ? strtolower($tenantConfig->getClientConfig('indexName')) : strtolower($this->name);
+        $this->logger = $pimcoreEcommerceOsLogger;
+        $this->indexName = strtolower(($tenantConfig->getClientConfig('indexName')) ?: $this->name);
     }
 
     /**
@@ -231,15 +231,16 @@ protected function createMappingAttributes(): array
                     }
                 }
 
-                if ($type == ProductListInterface::PRODUCT_TYPE_OBJECT) { //object doesn't support index or store
+                //object doesn't support index or store
+                if ($type === ProductListInterface::PRODUCT_TYPE_OBJECT) {
                     $mapping = ['type' => $type];
                 }
 
                 if (!$attribute->getOption('store')) {
                     $mapping['store'] = false;
                 }
 
-                if ($type == ProductListInterface::PRODUCT_TYPE_OBJECT || $type == 'nested') {
+                if ($type === ProductListInterface::PRODUCT_TYPE_OBJECT || $type === 'nested') {
                     unset($mapping['store']);
                 }