Set amount to the subtotal when the discount amount exceeds the subtotal #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdreesen
reviewed
Sep 30, 2024
jan888adams
force-pushed
the
fix-cart-discount-applied-to-the-total-price-instead-of-the-subtotal
branch
from
5ae13a1 to
f40dc6c
Compare
|
Not sure, if we should make that behavior configurable? WDYT? |
|
That sounds like a good idea. I would implement the current behavior as the default, with an option to switch to the new calculation. Additionally, I would apply the change only to the fixed amount and deprecate the old method of calculating cart discounts with fixed amounts. |
|
please just update the english translation file. the rest is translated via poeditor, see also https://pimcore.com/docs/platform/Pimcore/Multi_Language_i18n/Admin_Translations/#adding-your-own-admin-languages-since-v636 |
fashxp
requested changes
Oct 9, 2024
jan888adams
force-pushed
the
fix-cart-discount-applied-to-the-total-price-instead-of-the-subtotal
branch
from
991fd9a to
fad0b13
Compare
fashxp
approved these changes
Oct 10, 2024
|
thanks again! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cart discount reduces the total cart price, including price modifications like shipping costs. This behavior differs from percentage discounts, which only apply to the subtotal and do not affect additional costs.
This is fixed by setting the discount amount to the subtotal when the discount amount exceeds the subtotal.
Resolves: #199