Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Update webpack #211

Merged
merged 6 commits into from
Dec 2, 2024
Merged

[Task] Update webpack #211

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a7ca22d
Update webpack
mattamon Nov 5, 2024
4735a6e
Support both versions
mattamon Nov 26, 2024
b16abf7
Upgrading since core requires at least 1.7
mattamon Nov 26, 2024
78e8c4a
Update composer.json
mattamon Nov 26, 2024
6226f48
temp change for testing purposes
kingjia90 Nov 29, 2024
b86bfca
revert
kingjia90 Nov 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"pimcore/personalization-bundle": "^1.0",
"pimcore/google-marketing-bundle": "^1.0",
"knplabs/knp-paginator-bundle": "^6.0.0",
"symfony/webpack-encore-bundle": "^1.13.2",
"symfony/webpack-encore-bundle": "^1.17",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattamon I think we could support both versions. Also in admin-ui-classic-bundle. WDYT?

Suggested change
"symfony/webpack-encore-bundle": "^1.17",
"symfony/webpack-encore-bundle": "^1.13.2 || ^2.0",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah but I would at least already set it to 1.17 so like ^1.17 || ^2.0

"symfony/form": "^6.2"
},
"require-dev": {
Expand Down
Loading