Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task] Add mimeType to asset grid options #651

Merged
merged 2 commits into from
Jan 7, 2025
Merged

[Task] Add mimeType to asset grid options #651

merged 2 commits into from
Jan 7, 2025

Conversation

martineiber
Copy link
Contributor

Changes in this pull request

MimeType was added later here in the Core.. This PR now adds it also to Studio.
pimcore/pimcore#17941

Additional info

@martineiber martineiber self-assigned this Jan 7, 2025
@martineiber martineiber changed the title [Task] Add mimeType to asset grid. [Task] Add mimeType to asset grid options Jan 7, 2025
@martineiber martineiber marked this pull request as ready for review January 7, 2025 14:06
@martineiber martineiber requested review from Corepex and lukmzig January 7, 2025 14:06
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 7, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Corepex
Corepex approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@Corepex Corepex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lukmzig
lukmzig approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@lukmzig lukmzig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
image

@martineiber martineiber merged commit 278b22a into 1.x Jan 7, 2025
13 checks passed
@martineiber martineiber deleted the add-mime-type-to-asset branch January 7, 2025 14:12
@github-actions github-actions bot locked and limited conversation to collaborators Jan 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lukmzig lukmzig lukmzig approved these changes

@Corepex Corepex Corepex approved these changes

Assignees

@martineiber martineiber

Labels
Task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@martineiber @Corepex @lukmzig