Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: xixirangrang <[email protected]>
  • Loading branch information
2 people authored and ti-chi-bot committed Jan 17, 2024
1 parent 1c5f83a commit 0906d64
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion en/deploy-tiproxy.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ If you need to deploy TiProxy for an existing TiDB cluster, follow these steps:

> **Note:**
>
> If your server does not have access to the Internet, refer to [Deploy a TiDB Cluster](deploy-on-general-kubernetes.md#deploy-the-tidb-cluster) to download the `pingcap/tiproxy` Docker image to a machine with access to the Internet and then upload the Docker image to your server. Then, use `docker load` to install the Docker image on your server.
> If your server does not have access to the internet, refer to [Deploy a TiDB Cluster](deploy-on-general-kubernetes.md#deploy-the-tidb-cluster) to download the `pingcap/tiproxy` Docker image to a machine with access to the internet and then upload the Docker image to your server. Then, use `docker load` to install the Docker image on your server.
1. Edit the TidbCluster Custom Resource (CR):

Expand Down
2 changes: 1 addition & 1 deletion en/enable-tls-between-components.md
Original file line number Diff line number Diff line change
Expand Up @@ -414,7 +414,7 @@ This section describes how to issue certificates using two methods: `cfssl` and
cfssl print-defaults csr > tiproxy-server.json
```
2. Edit this file to change the `CN`, `hosts` attributes:
2. Edit this file to change the `CN` and `hosts` attributes:
```json
...
Expand Down
4 changes: 2 additions & 2 deletions en/scale-a-tidb-cluster.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ Horizontally scaling TiDB means that you scale TiDB out or in by adding or remov

### Horizontally scale PD, TiKV, TiDB, and TiProxy

To scale PD, TiKV, TiDB, or TiProxy horizontally, use kubectl to modify `spec.pd.replicas`, `spec.tikv.replicas`, `spec.tidb.replicas`, and `spec.tiproxy.replicas` in the `TidbCluster` object of the cluster to a desired value.
To scale PD, TiKV, TiDB, or TiProxy horizontally, use kubectl to modify `spec.pd.replicas`, `spec.tikv.replicas`, `spec.tidb.replicas`, and `spec.tiproxy.replicas` in the `TidbCluster` object of the cluster to desired values.

1. Modify the `replicas` value of a component as needed. For example, configure the `replicas` value of PD to 3:

Expand Down Expand Up @@ -167,7 +167,7 @@ Vertically scaling TiDB means that you scale TiDB up or down by increasing or de
This section describes how to vertically scale up or scale down components including PD, TiKV, TiDB, TiProxy, TiFlash, and TiCDC.
- To scale up or scale down PD, TiKV, TiDB, and TiProxy, use kubectl to modify `spec.pd.resources`, `spec.tikv.resources`, and `spec.tidb.resources` in the `TidbCluster` object that corresponds to the cluster to a desired value.
- To scale up or scale down PD, TiKV, TiDB, and TiProxy, use kubectl to modify `spec.pd.resources`, `spec.tikv.resources`, and `spec.tidb.resources` in the `TidbCluster` object that corresponds to the cluster to desired values.
- To scale up or scale down TiFlash, modify the value of `spec.tiflash.resources`.
Expand Down

0 comments on commit 0906d64

Please sign in to comment.