Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove spaces in options #2452

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Remove spaces in options #2452

merged 1 commit into from
Sep 26, 2023

Conversation

chenmin1992
Copy link
Contributor

First-time contributors' checklist

What is changed, added, or deleted? (Required)

Remove some spaces in the option, which cause "error: unknown flag: --from-", when create secrete from command line.

Which TiDB Operator version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v1.5 (TiDB Operator 1.5 versions)
  • v1.4 (TiDB Operator 1.4 versions)
  • v1.3 (TiDB Operator 1.3 versions)
  • v1.2 (TiDB Operator 1.2 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

@ti-chi-bot ti-chi-bot bot added contribution This PR is from a community contributor. missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 26, 2023
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 26, 2023
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 26, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 26, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-26 03:17:18.686293714 +0000 UTC m=+331228.404635927: ☑️ agreed by csuzhangxc.
  • 2023-09-26 07:11:02.748969502 +0000 UTC m=+345252.467311719: ☑️ agreed by ran-huang.

@chenmin1992
Copy link
Contributor Author

这移出 org 很不方便啊,通知都发到个人邮箱了。

@ran-huang
Copy link
Contributor

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ran-huang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Sep 26, 2023
@ti-chi-bot ti-chi-bot bot merged commit 0016eca into pingcap:master Sep 26, 2023
11 checks passed
@ran-huang ran-huang added needs-cherry-pick-release-1.3 Should cherry pick this PR to release-1.3 branch. needs-cherry-pick-release-1.4 Should cherry pick this PR to release-1.4 branch. needs-cherry-pick-release-1.5 Should cherry pick this PR to release-1.5 branch. translation/no-need The changes in this PR don't need to be translated. labels Sep 26, 2023
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Sep 26, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Sep 26, 2023
6 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-1.4: #2453.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-1.5: #2455.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-1.3: #2454.

ti-chi-bot bot pushed a commit that referenced this pull request Sep 26, 2023
ti-chi-bot bot pushed a commit that referenced this pull request Sep 26, 2023
ti-chi-bot bot pushed a commit that referenced this pull request Sep 26, 2023
@chenmin1992 chenmin1992 deleted the patch-1 branch September 26, 2023 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved contribution This PR is from a community contributor. lgtm needs-cherry-pick-release-1.3 Should cherry pick this PR to release-1.3 branch. needs-cherry-pick-release-1.4 Should cherry pick this PR to release-1.4 branch. needs-cherry-pick-release-1.5 Should cherry pick this PR to release-1.5 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/no-need The changes in this PR don't need to be translated.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants