Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecated-tikv-importer-in-operator #2461

Merged
merged 3 commits into from
Nov 13, 2023
Merged

deprecated-tikv-importer-in-operator #2461

merged 3 commits into from
Nov 13, 2023

Conversation

Frank945946
Copy link
Contributor

First-time contributors' checklist

Delete the description about Mydumper and tikv-importer in the docs

Which TiDB Operator version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v1.5 (TiDB Operator 1.5 versions)
  • v1.4 (TiDB Operator 1.4 versions)
  • v1.3 (TiDB Operator 1.3 versions)
  • v1.2 (TiDB Operator 1.2 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

@ti-chi-bot ti-chi-bot bot added contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. labels Oct 19, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 19, 2023

Welcome @Frank945946!

It looks like this is your first PR to pingcap/docs-tidb-operator 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to pingcap/docs-tidb-operator. 😃

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 19, 2023
@Oreoxmt Oreoxmt self-assigned this Oct 19, 2023
@Oreoxmt Oreoxmt added the translation/doing This PR’s assignee is translating this PR. label Oct 19, 2023
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Oct 19, 2023
@Oreoxmt Oreoxmt added the missing-translation-status This PR does not have translation status info. label Oct 19, 2023
@Oreoxmt Oreoxmt requested a review from csuzhangxc October 19, 2023 08:17
@Oreoxmt Oreoxmt added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Oct 19, 2023
@ti-chi-bot ti-chi-bot bot removed missing-translation-status This PR does not have translation status info. labels Oct 19, 2023
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 20, 2023
@Oreoxmt Oreoxmt added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 20, 2023
csuzhangxc
csuzhangxc reviewed Oct 20, 2023
View reviewed changes
en/restore-data-using-tidb-lightning.md

TiDB Lightning supports three backends: `Importer-backend`, `Local-backend`, and `TiDB-backend`. For the differences of these backends and how to choose backends, see [TiDB Lightning Backends](https://docs.pingcap.com/tidb/stable/tidb-lightning-backends).

- For `Importer-backend`, both tikv-importer and tidb-lightning need to be deployed.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update the above "TiDB Lightning supports three backends: Importer-backend," too?

@CLAassistant
Copy link

CLAassistant commented Oct 25, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 26, 2023

@D3Hunter: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the lgtm label Oct 26, 2023
@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 26, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 26, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-20 03:32:27.309966734 +0000 UTC m=+1973544.897076864: ☑️ agreed by Oreoxmt.
  • 2023-10-26 03:13:55.534690734 +0000 UTC m=+2490833.121800879: ☑️ agreed by lichunzhu.

@Oreoxmt Oreoxmt requested a review from ran-huang October 27, 2023 06:42
@Oreoxmt Oreoxmt added needs-cherry-pick-release-1.5 Should cherry pick this PR to release-1.5 branch. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Nov 13, 2023
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Nov 13, 2023

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 13, 2023
@ti-chi-bot ti-chi-bot bot merged commit 0eb7d04 into pingcap:master Nov 13, 2023
13 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-1.5: #2468.

ti-chi-bot pushed a commit to ti-chi-bot/docs-tidb-operator that referenced this pull request Nov 13, 2023
@Frank945946 @ti-chi-bot
deprecated-tikv-importer-in-operator (pingcap#2461)
0906684
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 13, 2023
Merged
6 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Nov 13, 2023
@ti-chi-bot
deprecated-tikv-importer-in-operator (#2461) (#2468)
31312fa
@Oreoxmt Oreoxmt added the needs-cherry-pick-release-1.4 Should cherry pick this PR to release-1.4 branch. label Nov 14, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-1.4: #2469.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 14, 2023
Merged
6 tasks
ti-chi-bot pushed a commit to ti-chi-bot/docs-tidb-operator that referenced this pull request Nov 14, 2023
@Frank945946 @ti-chi-bot
This is an automated cherry-pick of pingcap#2461
786693e 
Signed-off-by: ti-chi-bot <[email protected]>
ti-chi-bot bot pushed a commit that referenced this pull request Nov 14, 2023
@ti-chi-bot
deprecated-tikv-importer-in-operator (#2461) (#2469)
a8afa08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@csuzhangxc csuzhangxc csuzhangxc left review comments

@ran-huang ran-huang ran-huang approved these changes

@lichunzhu lichunzhu lichunzhu approved these changes

@D3Hunter D3Hunter D3Hunter approved these changes

@Benjamin2037 Benjamin2037 Awaiting requested review from Benjamin2037

Assignees

@Oreoxmt Oreoxmt

Labels
approved contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. lgtm needs-cherry-pick-release-1.4 Should cherry pick this PR to release-1.4 branch. needs-cherry-pick-release-1.5 Should cherry pick this PR to release-1.5 branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Frank945946 @CLAassistant @Oreoxmt @ti-chi-bot @csuzhangxc @D3Hunter @lichunzhu @ran-huang