Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: fix vale runs #2588

Merged
merged 1 commit into from
Jul 9, 2024
Merged

CI: fix vale runs #2588

merged 1 commit into from
Jul 9, 2024

Conversation

Oreoxmt
Copy link
Collaborator

@Oreoxmt Oreoxmt commented Jul 5, 2024 •
edited
Loading

What is changed, added, or deleted? (Required)

Fix the issue that Value fails to run.

Which TiDB Operator version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v1.6 (TiDB Operator 1.6 versions)
  • v1.5 (TiDB Operator 1.5 versions)
  • v1.4 (TiDB Operator 1.4 versions)
  • v1.3 (TiDB Operator 1.3 versions)
  • v1.2 (TiDB Operator 1.2 versions)

What is the related PR or file link(s)?

@Oreoxmt Oreoxmt added translation/no-need The changes in this PR don't need to be translated. needs-cherry-pick-release-1.2 Should cherry pick this PR to release-1.2 branch. needs-cherry-pick-release-1.3 Should cherry pick this PR to release-1.3 branch. needs-cherry-pick-release-1.4 Should cherry pick this PR to release-1.4 branch. needs-cherry-pick-release-1.5 Should cherry pick this PR to release-1.5 branch. needs-cherry-pick-release-1.6 Should cherry pick this PR to release-1.6 branch. labels Jul 5, 2024
@Oreoxmt Oreoxmt self-assigned this Jul 5, 2024
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 5, 2024
@Oreoxmt Oreoxmt force-pushed the fix/ci-vale branch 2 times, most recently from 203575f to 906d89f Compare July 5, 2024 07:17
@Oreoxmt Oreoxmt requested a review from qiancai July 9, 2024 03:19
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 9, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-09 03:48:02.835922858 +0000 UTC m=+329380.071156970: ☑️ agreed by qiancai.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 9, 2024
@Oreoxmt Oreoxmt added the lgtm label Jul 9, 2024
@Oreoxmt
Copy link
Collaborator Author

Oreoxmt commented Jul 9, 2024

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jul 9, 2024
@ti-chi-bot ti-chi-bot bot merged commit dd914ed into pingcap:master Jul 9, 2024
25 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-1.6: #2594.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 9, 2024
Merged
6 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-1.2: #2595.

This was referenced Jul 9, 2024
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-1.3: #2596.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-1.4: #2597.

This was referenced Jul 9, 2024
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-1.5: #2598.

ti-chi-bot bot pushed a commit that referenced this pull request Jul 9, 2024
@ti-chi-bot
CI: fix vale runs (#2588) (#2597)
536ca10
ti-chi-bot bot pushed a commit that referenced this pull request Jul 9, 2024
@ti-chi-bot
CI: fix vale runs (#2588) (#2594)
100a7e1
ti-chi-bot bot pushed a commit that referenced this pull request Jul 9, 2024
@ti-chi-bot
CI: fix vale runs (#2588) (#2598)
c3327e3
ti-chi-bot bot pushed a commit that referenced this pull request Jul 9, 2024
@ti-chi-bot
CI: fix vale runs (#2588) (#2595)
6977797
ti-chi-bot bot pushed a commit that referenced this pull request Jul 9, 2024
@ti-chi-bot
CI: fix vale runs (#2588) (#2596)
3cdf7f8
@Oreoxmt Oreoxmt deleted the fix/ci-vale branch July 10, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiancai qiancai qiancai approved these changes

Assignees

@Oreoxmt Oreoxmt

Labels
approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-1.2 Should cherry pick this PR to release-1.2 branch. needs-cherry-pick-release-1.3 Should cherry pick this PR to release-1.3 branch. needs-cherry-pick-release-1.4 Should cherry pick this PR to release-1.4 branch. needs-cherry-pick-release-1.5 Should cherry pick this PR to release-1.5 branch. needs-cherry-pick-release-1.6 Should cherry pick this PR to release-1.6 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/no-need The changes in this PR don't need to be translated.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Oreoxmt @ti-chi-bot @qiancai