Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update log backup user docs #2641

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

update log backup user docs #2641

wants to merge 24 commits into from

Conversation

RidRisR
Copy link

@RidRisR RidRisR commented Oct 25, 2024 •
edited
Loading

First-time contributors' checklist

What is changed, added, or deleted? (Required)

Added the description of new TiDB operator interface, including:

  1. Description of new spec field
  2. Introduction of auto-stop fucntion
  3. new example of log backup wrokflow

Which TiDB Operator version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v1.6 (TiDB Operator 1.6 versions)
  • v1.5 (TiDB Operator 1.5 versions)
  • v1.4 (TiDB Operator 1.4 versions)
  • v1.3 (TiDB Operator 1.3 versions)
  • v1.2 (TiDB Operator 1.2 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

@ti-chi-bot ti-chi-bot bot added the first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. label Oct 25, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 25, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign toutdesuite for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@CLAassistant
Copy link

CLAassistant commented Oct 25, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 25, 2024
csuzhangxc
csuzhangxc reviewed Nov 5, 2024
View reviewed changes
en/backup-restore-overview.md Outdated Show resolved Hide resolved
en/backup-to-aws-s3-using-br.md Show resolved Hide resolved
en/backup-to-aws-s3-using-br.md Outdated Show resolved Hide resolved
en/backup-to-aws-s3-using-br.md Outdated Show resolved Hide resolved
en/backup-to-aws-s3-using-br.md Outdated Show resolved Hide resolved
en/backup-to-aws-s3-using-br.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 12, 2024
@RidRisR RidRisR requested a review from csuzhangxc November 18, 2024 04:20
csuzhangxc
csuzhangxc reviewed Nov 18, 2024
View reviewed changes
en/backup-to-aws-s3-using-br.md Outdated Show resolved Hide resolved
en/backup-restore-cr.md Show resolved Hide resolved
zh/backup-restore-overview.md Outdated Show resolved Hide resolved
zh/backup-to-aws-s3-using-br.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 28, 2024
csuzhangxc
csuzhangxc reviewed Nov 28, 2024
View reviewed changes
zh/backup-restore-overview.md Outdated Show resolved Hide resolved
en/backup-to-aws-s3-using-br.md Outdated Show resolved Hide resolved
en/backup-to-aws-s3-using-br.md Outdated Show resolved Hide resolved
en/backup-to-aws-s3-using-br.md Outdated Show resolved Hide resolved
en/backup-to-aws-s3-using-br.md Outdated Show resolved Hide resolved
en/backup-to-aws-s3-using-br.md Outdated Show resolved Hide resolved
en/backup-to-gcs-using-br.md Outdated Show resolved Hide resolved
RidRisR and others added 2 commits November 28, 2024 11:24
@RidRisR @csuzhangxc
Update zh/backup-restore-overview.md
dc23a0d 
Co-authored-by: Cody (Xuecheng) Zhang <[email protected]>
@RidRisR @csuzhangxc
Update en/backup-to-aws-s3-using-br.md
ef1a001 
Co-authored-by: Cody (Xuecheng) Zhang <[email protected]>
@RidRisR RidRisR requested a review from csuzhangxc November 28, 2024 09:34
@RidRisR RidRisR requested a review from csuzhangxc November 29, 2024 06:44
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 29, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-29 07:08:16.649605029 +0000 UTC m=+793084.269259542: ☑️ agreed by csuzhangxc.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 29, 2024
@csuzhangxc csuzhangxc requested a review from Oreoxmt November 29, 2024 07:08
@csuzhangxc
Copy link
Member

@Oreoxmt As this feature is only available in the coming v1.6.1 and 1.5.5, should we not merge it until this version is released?

@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Nov 29, 2024

@csuzhangxc Yes, we can merge this PR on the release day of v1.6.1 or v1.5.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csuzhangxc csuzhangxc csuzhangxc approved these changes

@Oreoxmt Oreoxmt Awaiting requested review from Oreoxmt

Assignees
No one assigned
Labels
first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. missing-translation-status This PR does not have translation status info. needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RidRisR @CLAassistant @csuzhangxc @Oreoxmt