Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update OWNERS #2654

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Update OWNERS #2654

merged 1 commit into from
Dec 6, 2024

Conversation

qiancai
Copy link
Collaborator

@qiancai qiancai commented Dec 6, 2024 •
edited
Loading

What is changed, added, or deleted? (Required)

Add individuals who are no longer actively approving PRs to the emeritus approvers list.

Which TiDB Operator version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v1.6 (TiDB Operator 1.6 versions)
  • v1.5 (TiDB Operator 1.5 versions)
  • v1.4 (TiDB Operator 1.4 versions)
  • v1.3 (TiDB Operator 1.3 versions)
  • v1.2 (TiDB Operator 1.2 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 6, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 6, 2024
lilin90
lilin90 approved these changes Dec 6, 2024
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 6, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 6, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-06 08:11:06.973200149 +0000 UTC m=+1401654.592854664: ☑️ agreed by csuzhangxc.
  • 2024-12-06 08:47:20.828835849 +0000 UTC m=+1403828.448490360: ☑️ agreed by lilin90.

@lilin90 lilin90 added the translation/no-need The changes in this PR don't need to be translated. label Dec 6, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Dec 6, 2024
@lilin90
Copy link
Member

lilin90 commented Dec 6, 2024

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lilin90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 6, 2024
@ti-chi-bot ti-chi-bot bot merged commit 160335c into pingcap:master Dec 6, 2024
14 checks passed
@lilin90 lilin90 mentioned this pull request Dec 9, 2024
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilin90 lilin90 lilin90 approved these changes

@csuzhangxc csuzhangxc csuzhangxc approved these changes

Assignees
No one assigned
Labels
approved lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/no-need The changes in this PR don't need to be translated.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qiancai @lilin90 @csuzhangxc