Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add div_precision_increment system variable doc #16736

Merged
merged 7 commits into from
Mar 19, 2024
Merged

Add div_precision_increment system variable doc #16736

merged 7 commits into from
Mar 19, 2024

Conversation

yibin87
Copy link
Contributor

@yibin87 yibin87 commented Mar 12, 2024 •
edited by hfxsd
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.0 (TiDB 8.0 versions)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added the first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. label Mar 12, 2024
@CLAassistant
Copy link

CLAassistant commented Mar 12, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@yibin87 yibin87 requested review from windtalker and hfxsd March 12, 2024 11:54
@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 12, 2024
@hfxsd hfxsd added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v8.0 and removed missing-translation-status This PR does not have translation status info. labels Mar 12, 2024
@hfxsd hfxsd self-assigned this Mar 12, 2024
hfxsd
hfxsd reviewed Mar 12, 2024
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
@yibin87 @hfxsd
Update system-variables.md
96fcd79 
Co-authored-by: xixirangrang <[email protected]>
@hfxsd hfxsd requested a review from joey-yez March 12, 2024 12:00
hfxsd
hfxsd reviewed Mar 12, 2024
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
@hfxsd hfxsd requested a review from Oreoxmt March 12, 2024 12:05
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 12, 2024
windtalker
windtalker reviewed Mar 13, 2024
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
@yibin87
Address comments
c3aa465 
Signed-off-by: yibin <[email protected]>
@yibin87 yibin87 requested a review from windtalker March 13, 2024 07:51
windtalker
windtalker approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 13, 2024

@windtalker: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

joey-yez
joey-yez reviewed Mar 13, 2024
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
Oreoxmt
Oreoxmt reviewed Mar 14, 2024
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 14, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 15, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 15, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-14 08:02:45.492937324 +0000 UTC m=+931792.515183711: ☑️ agreed by Oreoxmt.
  • 2024-03-15 01:54:51.36806617 +0000 UTC m=+996118.390312556: ☑️ agreed by hfxsd.

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 15, 2024

@joey-yez: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hfxsd
Copy link
Collaborator

hfxsd commented Mar 19, 2024

/approve

@ti-chi-bot ti-chi-bot bot added the approved label Mar 19, 2024
@hfxsd hfxsd closed this Mar 19, 2024
@hfxsd hfxsd reopened this Mar 19, 2024
@hfxsd
Copy link
Collaborator

hfxsd commented Mar 19, 2024

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit db4a3e5 into pingcap:master Mar 19, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joey-yez joey-yez joey-yez approved these changes

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@hfxsd hfxsd hfxsd approved these changes

@windtalker windtalker windtalker approved these changes

Assignees

@hfxsd hfxsd

Labels
approved first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yibin87 @CLAassistant @hfxsd @windtalker @Oreoxmt @joey-yez