Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pd: support pd microservices #16803

Merged
merged 15 commits into from
Mar 25, 2024
Merged

Conversation

qiancai
Copy link
Collaborator

@qiancai qiancai commented Mar 21, 2024

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)

What is the related PR or file link(s)?

@qiancai qiancai added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v8.0 labels Mar 21, 2024
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 21, 2024
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 21, 2024
github-actions bot pushed a commit to qiancai/pingcap-docsite-preview that referenced this pull request Mar 21, 2024
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 21, 2024
github-actions bot pushed a commit to qiancai/pingcap-docsite-preview that referenced this pull request Mar 21, 2024
@qiancai qiancai self-assigned this Mar 22, 2024
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

pd-microservices.md Outdated Show resolved Hide resolved
pd-microservices.md Outdated Show resolved Hide resolved
pd-microservices.md Outdated Show resolved Hide resolved
tiup/tiup-playground.md Outdated Show resolved Hide resolved
Copy link

ti-chi-bot bot commented Mar 22, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-22 08:15:55.7083157 +0000 UTC m=+1623782.730562089: ☑️ agreed by lilin90.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 22, 2024
pd-microservices.md Outdated Show resolved Hide resolved
pd-microservices.md Outdated Show resolved Hide resolved
pd-microservices.md Outdated Show resolved Hide resolved
pd-microservices.md Outdated Show resolved Hide resolved
pd-microservices.md Outdated Show resolved Hide resolved
Copy link

ti-chi-bot bot commented Mar 25, 2024

@HuSharp: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pd-microservices.md Outdated Show resolved Hide resolved
pd-microservices.md Outdated Show resolved Hide resolved
pd-microservices.md Outdated Show resolved Hide resolved
pd-microservices.md Outdated Show resolved Hide resolved
tiup/tiup-playground.md Outdated Show resolved Hide resolved
@qiancai
Copy link
Collaborator Author

qiancai commented Mar 25, 2024

/approve

@qiancai qiancai added the lgtm label Mar 25, 2024
Copy link

ti-chi-bot bot commented Mar 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Mar 25, 2024
@qiancai
Copy link
Collaborator Author

qiancai commented Mar 25, 2024

/retest

@ti-chi-bot ti-chi-bot bot merged commit e3623db into pingcap:master Mar 25, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants