Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ELT and EXPORT_SET examples #16934

Merged
merged 17 commits into from
Apr 26, 2024
Merged

Add ELT and EXPORT_SET examples #16934

merged 17 commits into from
Apr 26, 2024

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Apr 2, 2024

What is changed, added or deleted? (Required)

Closes #15485

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.1 (TiDB 8.1 versions)
  • v8.0 (TiDB 8.0 versions)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@dveeden dveeden requested a review from qiancai April 2, 2024 07:55
@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 2, 2024
@dveeden
Copy link
Contributor Author

dveeden commented Apr 2, 2024

@qiancai @kennytm The JSON function docs have things like JSON_KEYS(json_doc[, path]) while this page has ELT() and not ELT(element, str [,str, ...]). I think the function arguments should be in the documentation.

Should we make that the same for all pages? Or should we use EBNF for this?

@Oreoxmt Oreoxmt added type/enhancement The issue or PR belongs to an enhancement. area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. needs-cherry-pick-release-8.0 translation/doing This PR's assignee is translating this PR. labels Apr 2, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Apr 2, 2024
@Oreoxmt Oreoxmt self-assigned this Apr 2, 2024
@Oreoxmt Oreoxmt requested review from Oreoxmt and removed request for Oreoxmt April 2, 2024 07:58
@Oreoxmt Oreoxmt assigned qiancai and unassigned Oreoxmt Apr 2, 2024
@kennytm
Copy link
Contributor

kennytm commented Apr 2, 2024

@dveeden No need to use EBNF for a function signature, that's overkill for such simple syntax 😂

@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Apr 7, 2024

@dveeden Could you please invite a tech reviewer? Thanks!

@dveeden dveeden requested review from mjonss and lcwangchao April 7, 2024 08:52
mjonss
mjonss approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@mjonss mjonss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With some minor suggestions.

functions-and-operators/string-functions.md Outdated Show resolved Hide resolved
functions-and-operators/string-functions.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 8, 2024

@mjonss: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

With some minor suggestions.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

qiancai
qiancai approved these changes Apr 19, 2024
View reviewed changes
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

functions-and-operators/string-functions.md Outdated Show resolved Hide resolved
functions-and-operators/string-functions.md Outdated Show resolved Hide resolved
functions-and-operators/string-functions.md Outdated Show resolved Hide resolved
functions-and-operators/string-functions.md Outdated Show resolved Hide resolved
functions-and-operators/string-functions.md Outdated Show resolved Hide resolved
functions-and-operators/string-functions.md Outdated Show resolved Hide resolved
functions-and-operators/string-functions.md Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 19, 2024
@qiancai qiancai mentioned this pull request Apr 24, 2024
Merged
17 tasks
@qiancai qiancai added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Apr 24, 2024
@hfxsd hfxsd self-requested a review April 25, 2024 06:28
hfxsd
hfxsd reviewed Apr 25, 2024
View reviewed changes
functions-and-operators/string-functions.md Outdated Show resolved Hide resolved
functions-and-operators/string-functions.md Outdated Show resolved Hide resolved
functions-and-operators/string-functions.md Outdated Show resolved Hide resolved
functions-and-operators/string-functions.md Outdated Show resolved Hide resolved
functions-and-operators/string-functions.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 25, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 25, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-19 09:36:46.074012101 +0000 UTC m=+590025.185058550: ☑️ agreed by qiancai.
  • 2024-04-25 09:31:11.895516179 +0000 UTC m=+252628.635419086: ☑️ agreed by hfxsd.

@qiancai
Copy link
Collaborator

qiancai commented Apr 26, 2024

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Apr 26, 2024
@ti-chi-bot ti-chi-bot bot merged commit 7a30808 into pingcap:master Apr 26, 2024
8 of 9 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.0: #17375.

This was referenced Apr 26, 2024
Merged
Merged
ti-chi-bot bot pushed a commit that referenced this pull request Apr 26, 2024
@ti-chi-bot
Add ELT and EXPORT_SET examples (#16934) (#17375)
a600e5d
dveeden added a commit to dveeden/docs that referenced this pull request May 15, 2024
@dveeden
Add ELT and EXPORT_SET examples (pingcap#16934)
78b27ba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiancai qiancai qiancai approved these changes

@mjonss mjonss mjonss approved these changes

@hfxsd hfxsd hfxsd approved these changes

@lcwangchao lcwangchao Awaiting requested review from lcwangchao

Assignees

@qiancai qiancai

Labels
approved area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enrich instructions for string functions ELT() and EXPORT_SET()
7 participants
@dveeden @kennytm @Oreoxmt @qiancai @ti-chi-bot @mjonss @hfxsd