Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ebnf update #17099

Merged
merged 1 commit into from
Apr 22, 2024
Merged

ebnf update #17099

merged 1 commit into from
Apr 22, 2024

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Apr 9, 2024

What is changed, added or deleted? (Required)

Closes #17098

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.1 (TiDB 8.1 versions)
  • v8.0 (TiDB 8.0 versions)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@dveeden dveeden requested review from kennytm and Oreoxmt April 9, 2024 21:03
@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 9, 2024
@dveeden
Copy link
Contributor Author

dveeden commented Apr 9, 2024

@kennytm I think the TableRef(s) need to be extended/improved. What do you think?

Copy link

ti-chi-bot bot commented Apr 9, 2024

@kennytm: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kennytm
Copy link
Contributor

kennytm commented Apr 9, 2024

@dveeden TableRef expanded would be quite complicated though.

TableFactor ::=
    TableName PartitionNameList? TableAsName? AsOfClause? IndexHintList? TableSample?
|   SubSelect TableAsName?
|   "(" TableRefs ")"

JoinTable ::=
    TableRef ("CROSS" | "INNER" | ("LEFT" | "RIGHT") "OUTER"?)? "JOIN" TableRef ("ON" Expression | "USING" "(" ColumnNameList ")" )
|   TableRef "NATURAL" (("LEFT" | "RIGHT") "OUTER"?)? "JOIN" TableRef 
|   TableRef "STRAIGHT_JOIN" TableRef  ("ON" Expression)?

@Oreoxmt Oreoxmt removed their request for review April 10, 2024 09:46
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

ti-chi-bot bot commented Apr 22, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-22 06:31:46.679784937 +0000 UTC m=+838125.790831387: ☑️ agreed by lilin90.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 22, 2024
@lilin90 lilin90 added the translation/doing This PR's assignee is translating this PR. label Apr 22, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Apr 22, 2024
@lilin90 lilin90 added missing-translation-status This PR does not have translation status info. lgtm needs-cherry-pick-release-8.0 labels Apr 22, 2024
@lilin90
Copy link
Member

lilin90 commented Apr 22, 2024

/approve

Copy link

ti-chi-bot bot commented Apr 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lilin90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Apr 22, 2024
@ti-chi-bot ti-chi-bot bot merged commit a856870 into pingcap:master Apr 22, 2024
9 checks passed
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 22, 2024
17 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.0: #17297.

ti-chi-bot bot pushed a commit that referenced this pull request Apr 22, 2024
@lilin90 lilin90 removed the missing-translation-status This PR does not have translation status info. label Apr 22, 2024
@lilin90 lilin90 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sql-statements/sql-statement-update.md
4 participants