Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

br: add link to snapshot backup&restore metrics #19307

Merged
merged 1 commit into from
Nov 4, 2024
Merged

br: add link to snapshot backup&restore metrics #19307

merged 1 commit into from
Nov 4, 2024

Conversation

BornChanger
Copy link
Contributor

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 4, 2024
@Oreoxmt Oreoxmt self-assigned this Nov 4, 2024
@Oreoxmt Oreoxmt added type/enhancement The issue or PR belongs to an enhancement. translation/doing This PR's assignee is translating this PR. area/br Indicates that the Issue or PR belongs to the area of BR (Backup & Restore). needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.2 needs-cherry-pick-release-8.3 Should cherry pick this PR to release-8.3 branch. needs-cherry-pick-release-8.4 Should cherry pick this PR to release-8.4 branch. labels Nov 4, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Nov 4, 2024
@Oreoxmt Oreoxmt added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. labels Nov 4, 2024
Oreoxmt
Oreoxmt approved these changes Nov 4, 2024
View reviewed changes
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 4, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 4, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-04 06:39:30.541828956 +0000 UTC m=+850283.380984709: ☑️ agreed by Oreoxmt.

@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Nov 4, 2024

/approve

@Oreoxmt Oreoxmt added the lgtm label Nov 4, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 4, 2024
@BornChanger BornChanger force-pushed the add_snapshot_br_metrics branch from 1f7934f to 1c55941 Compare November 4, 2024 07:11
@BornChanger BornChanger force-pushed the add_snapshot_br_metrics branch from 1c55941 to 59c15f9 Compare November 4, 2024 07:12
@ti-chi-bot ti-chi-bot bot merged commit 292636b into master Nov 4, 2024
9 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #19308.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 4, 2024
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #19309.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 4, 2024
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #19310.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 4, 2024
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.2: #19311.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 4, 2024
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.3: #19312.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 4, 2024
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.4: #19313.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 4, 2024
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #19314.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 4, 2024
Merged
16 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Nov 4, 2024
@ti-chi-bot
br: add link to snapshot backup&restore metrics (#19307) (#19309)
1e0c208
ti-chi-bot bot pushed a commit that referenced this pull request Nov 4, 2024
@ti-chi-bot
br: add link to snapshot backup&restore metrics (#19307) (#19308)
0a4fa3a
ti-chi-bot bot pushed a commit that referenced this pull request Nov 4, 2024
@ti-chi-bot
br: add link to snapshot backup&restore metrics (#19307) (#19313)
cc074ea
ti-chi-bot bot pushed a commit that referenced this pull request Nov 4, 2024
@ti-chi-bot
br: add link to snapshot backup&restore metrics (#19307) (#19314)
b0aa17c
ti-chi-bot bot pushed a commit that referenced this pull request Nov 4, 2024
@ti-chi-bot
br: add link to snapshot backup&restore metrics (#19307) (#19310)
42f22cf
ti-chi-bot bot pushed a commit that referenced this pull request Nov 4, 2024
@ti-chi-bot
br: add link to snapshot backup&restore metrics (#19307) (#19312)
430693d
ti-chi-bot bot pushed a commit that referenced this pull request Nov 4, 2024
@ti-chi-bot
br: add link to snapshot backup&restore metrics (#19307) (#19311)
1404d21
@Oreoxmt Oreoxmt added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Nov 6, 2024
@Oreoxmt Oreoxmt mentioned this pull request Nov 6, 2024
Open
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@3pointer 3pointer 3pointer approved these changes

Assignees

@Oreoxmt Oreoxmt

Labels
approved area/br Indicates that the Issue or PR belongs to the area of BR (Backup & Restore). first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.3 Should cherry pick this PR to release-8.3 branch. needs-cherry-pick-release-8.4 Should cherry pick this PR to release-8.4 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BornChanger @Oreoxmt @ti-chi-bot @3pointer