Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tiproxy: add performance report of traffic capture #19335

Merged
merged 3 commits into from
Nov 7, 2024

Conversation

djshow832
Copy link
Contributor

What is changed, added or deleted? (Required)

  • Some community users gave feedback that they wanted the performance effect of traffic capture, so I did a performance test.
  • Meanwhile, a colleague wanted to see the sample of fail, so I added a sample.
  • Added more warnings as the PM required.
  • Fix wrong name of db tiproxy_traffic_replay.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 5, 2024
@djshow832 djshow832 requested a review from Oreoxmt November 5, 2024 08:41
@Oreoxmt Oreoxmt self-assigned this Nov 5, 2024
@Oreoxmt Oreoxmt added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v8.4 This PR/issue applies to TiDB v8.4. needs-cherry-pick-release-8.4 Should cherry pick this PR to release-8.4 branch. labels Nov 5, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Nov 5, 2024
tiproxy/tiproxy-performance-test.md Outdated Show resolved Hide resolved
tiproxy/tiproxy-performance-test.md Outdated Show resolved Hide resolved
tiproxy/tiproxy-traffic-replay.md Outdated Show resolved Hide resolved
tiproxy/tiproxy-traffic-replay.md Outdated Show resolved Hide resolved
tiproxy/tiproxy-traffic-replay.md Outdated Show resolved Hide resolved
tiproxy/tiproxy-traffic-replay.md Outdated Show resolved Hide resolved
tiproxy/tiproxy-traffic-replay.md Outdated Show resolved Hide resolved
@Oreoxmt Oreoxmt requested a review from qiancai November 6, 2024 10:31
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 6, 2024
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

tiproxy/tiproxy-traffic-replay.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 7, 2024
Copy link

ti-chi-bot bot commented Nov 7, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-06 10:31:51.01036673 +0000 UTC m=+1037023.849522261: ☑️ agreed by Oreoxmt.
  • 2024-11-07 05:37:27.119221097 +0000 UTC m=+1105759.958376638: ☑️ agreed by qiancai.

@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Nov 7, 2024

/approve

Copy link

ti-chi-bot bot commented Nov 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 7, 2024
@ti-chi-bot ti-chi-bot bot merged commit ac830b4 into pingcap:master Nov 7, 2024
9 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.4: #19352.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-8.4 Should cherry pick this PR to release-8.4 branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v8.4 This PR/issue applies to TiDB v8.4.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants