Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cdc: reformat Changefeed config and Server config #19654

Merged
merged 15 commits into from
Dec 24, 2024

Conversation

Oreoxmt
Copy link
Collaborator

@Oreoxmt Oreoxmt commented Dec 11, 2024

What is changed, added or deleted? (Required)

This PR is a first step. It converts the existing format of code blocks to the body heading format for config descriptions in CLI and Configuration Parameters of TiCDC Changefeeds | TiDB Docs and TiCDC Server Configurations | TiDB Docs, like that in TiDB Configuration File | TiDB Docs.

This PR doesn't add new descriptions, except describe some config value as 示例值 for now, because those config items have no description or default value. Some missing explanations need to be added in new PRs.

cdc: reformat Changefeed config and Server config
ref: #19522 and #19521

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@Oreoxmt Oreoxmt added the translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. label Dec 11, 2024
@Oreoxmt Oreoxmt self-assigned this Dec 11, 2024
@Oreoxmt
Copy link
Collaborator Author

Oreoxmt commented Dec 11, 2024

/hold

@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Dec 11, 2024
@Oreoxmt Oreoxmt added type/enhancement The issue or PR belongs to an enhancement. area/ticdc Indicates that the Issue or PR belongs to the area of TiCDC. labels Dec 11, 2024
Signed-off-by: Aolin <[email protected]>
@Oreoxmt
Copy link
Collaborator Author

Oreoxmt commented Dec 13, 2024

/cc @hfxsd

@ti-chi-bot ti-chi-bot bot requested a review from hfxsd December 13, 2024 02:56
@Oreoxmt Oreoxmt added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Dec 20, 2024
@Oreoxmt Oreoxmt requested a review from hfxsd December 20, 2024 07:32
ticdc/ticdc-changefeed-config.md Outdated Show resolved Hide resolved
ticdc/ticdc-changefeed-config.md Outdated Show resolved Hide resolved
ticdc/ticdc-changefeed-config.md Outdated Show resolved Hide resolved
ticdc/ticdc-changefeed-config.md Outdated Show resolved Hide resolved
ticdc/ticdc-changefeed-config.md Outdated Show resolved Hide resolved
ticdc/ticdc-changefeed-config.md Outdated Show resolved Hide resolved
ticdc/ticdc-changefeed-config.md Outdated Show resolved Hide resolved
ticdc/ticdc-changefeed-config.md Outdated Show resolved Hide resolved
ticdc/ticdc-changefeed-config.md Outdated Show resolved Hide resolved
ticdc/ticdc-changefeed-config.md Outdated Show resolved Hide resolved
@Oreoxmt Oreoxmt requested a review from hfxsd December 23, 2024 09:08
ticdc/ticdc-server-config.md Outdated Show resolved Hide resolved
Copy link

ti-chi-bot bot commented Dec 24, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-24 00:13:03.653524236 +0000 UTC m=+1520573.742326778: ☑️ agreed by hfxsd.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 24, 2024
Copy link

ti-chi-bot bot commented Dec 24, 2024

@hfxsd: Your lgtm message is repeated, so it is ignored.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Co-authored-by: xixirangrang <[email protected]>
@Oreoxmt Oreoxmt closed this Dec 24, 2024
@Oreoxmt Oreoxmt reopened this Dec 24, 2024
@Oreoxmt Oreoxmt added the lgtm label Dec 24, 2024
@Oreoxmt
Copy link
Collaborator Author

Oreoxmt commented Dec 24, 2024

/approve

Copy link

ti-chi-bot bot commented Dec 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 24, 2024
@Oreoxmt
Copy link
Collaborator Author

Oreoxmt commented Dec 24, 2024

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 24, 2024
@ti-chi-bot ti-chi-bot bot merged commit c699d17 into pingcap:master Dec 24, 2024
14 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #19782.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/ticdc Indicates that the Issue or PR belongs to the area of TiCDC. lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants