-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg: validate volume number for ebs snapshot restore #5292
pkg: validate volume number for ebs snapshot restore #5292
Conversation
Signed-off-by: BornChanger <[email protected]>
/run-e2e-tests |
/run-pull-e2e-kind |
/run-pull-e2e-kind-across-kubernetes |
/run-pull-e2e-kind-br |
/run-pull-e2e-kind-across-kubernetes |
/run-pull-e2e-kind-serial |
1 similar comment
/run-pull-e2e-kind-serial |
/run-pull-e2e-kind-across-kubernetes |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5292 +/- ##
==========================================
+ Coverage 57.44% 57.71% +0.27%
==========================================
Files 252 252
Lines 30593 30780 +187
==========================================
+ Hits 17575 17766 +191
+ Misses 11276 11271 -5
- Partials 1742 1743 +1
|
Signed-off-by: BornChanger <[email protected]>
/retest |
@BornChanger: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @WangLe1321 @csuzhangxc plta |
@BornChanger: GitHub didn't allow me to request PR reviews from the following users: WangLe1321, plta. Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @WangLe1321 |
@BornChanger: GitHub didn't allow me to request PR reviews from the following users: WangLe1321. Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: BornChanger <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: WangLe1321 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
New changes are detected. LGTM label has been removed. |
/test pull-e2e-kind-br |
@BornChanger: No presubmit jobs available for pingcap/tidb-operator@master In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/test pull-e2e-kind-br |
@wuhuizuo: No presubmit jobs available for pingcap/tidb-operator@master In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/run-pull-e2e-kind-br |
/cherry-pick release-1.5 |
@BornChanger: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/cherry-pick release-1.5 |
@csuzhangxc: new pull request could not be created: failed to create pull request against pingcap/tidb-operator#release-1.5 from head ti-chi-bot:cherry-pick-5292-to-release-1.5: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for ti-chi-bot:cherry-pick-5292-to-release-1.5."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request"} In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: BornChanger <[email protected]> Co-authored-by: BornChanger <[email protected]>
What problem does this PR solve?
Close #5287
What is changed and how does it work?
We will check if restore TC has the same volume number as the upstream cluster.
Code changes
Tests
Side effects
Related changes
Release Notes
Please refer to Release Notes Language Style Guide before writing the release note.