Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg: validate volume number for ebs snapshot restore #5292

Merged
merged 5 commits into from
Sep 27, 2023

Conversation

BornChanger
Copy link
Contributor

What problem does this PR solve?

Close #5287

What is changed and how does it work?

We will check if restore TC has the same volume number as the upstream cluster.

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


@BornChanger
Copy link
Contributor Author

/run-e2e-tests

@BornChanger
Copy link
Contributor Author

/run-pull-e2e-kind

@BornChanger
Copy link
Contributor Author

/run-pull-e2e-kind-across-kubernetes

@WangLe1321
Copy link
Contributor

/run-pull-e2e-kind-br

@WangLe1321
Copy link
Contributor

/run-pull-e2e-kind-across-kubernetes

@BornChanger
Copy link
Contributor Author

/run-pull-e2e-kind-serial

1 similar comment
@WangLe1321
Copy link
Contributor

/run-pull-e2e-kind-serial

@purelind
Copy link
Contributor

/run-pull-e2e-kind-across-kubernetes

@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2023

Codecov Report

Merging #5292 (010c96b) into master (3f8c788) will increase coverage by 0.27%.
The diff coverage is 90.32%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5292      +/-   ##
==========================================
+ Coverage   57.44%   57.71%   +0.27%     
==========================================
  Files         252      252              
  Lines       30593    30780     +187     
==========================================
+ Hits        17575    17766     +191     
+ Misses      11276    11271       -5     
- Partials     1742     1743       +1     
Flag Coverage Δ
unittest 57.71% <90.32%> (+0.27%) ⬆️

Signed-off-by: BornChanger <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/XL and removed size/L labels Sep 25, 2023
@BornChanger
Copy link
Contributor Author

/retest

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 25, 2023

@BornChanger: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BornChanger
Copy link
Contributor Author

/cc @WangLe1321 @csuzhangxc plta

@ti-chi-bot ti-chi-bot bot requested a review from csuzhangxc September 25, 2023 16:21
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 25, 2023

@BornChanger: GitHub didn't allow me to request PR reviews from the following users: WangLe1321, plta.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @WangLe1321 @csuzhangxc plta

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BornChanger
Copy link
Contributor Author

/cc @WangLe1321

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 25, 2023

@BornChanger: GitHub didn't allow me to request PR reviews from the following users: WangLe1321.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @WangLe1321

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: BornChanger <[email protected]>
@ti-chi-bot ti-chi-bot bot added the lgtm label Sep 27, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: WangLe1321

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Sep 27, 2023
@ti-chi-bot ti-chi-bot bot removed the lgtm label Sep 27, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 27, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-27 03:10:49.795578352 +0000 UTC m=+417239.513920569: ☑️ agreed by WangLe1321.
  • 2023-09-27 03:18:47.100832094 +0000 UTC m=+417716.819174296: ✖️🔁 reset by ti-chi-bot[bot].

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 27, 2023

New changes are detected. LGTM label has been removed.

@BornChanger
Copy link
Contributor Author

/test pull-e2e-kind-br

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 27, 2023

@BornChanger: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind-br

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wuhuizuo
Copy link
Contributor

/ok-to-test

@wuhuizuo
Copy link
Contributor

/test pull-e2e-kind-br

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 27, 2023

@wuhuizuo: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind-br

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wuhuizuo
Copy link
Contributor

/run-pull-e2e-kind-br

@csuzhangxc csuzhangxc merged commit ba5dc7a into pingcap:master Sep 27, 2023
2 of 4 checks passed
@BornChanger
Copy link
Contributor Author

/cherry-pick release-1.5

@ti-chi-bot
Copy link
Member

@BornChanger: new pull request created to branch release-1.5: #5310.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@csuzhangxc
Copy link
Member

/cherry-pick release-1.5

@ti-chi-bot
Copy link
Member

@csuzhangxc: new pull request could not be created: failed to create pull request against pingcap/tidb-operator#release-1.5 from head ti-chi-bot:cherry-pick-5292-to-release-1.5: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for ti-chi-bot:cherry-pick-5292-to-release-1.5."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request"}

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

csuzhangxc pushed a commit that referenced this pull request Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants