-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ebs br: resume gc and scheduler when volume snapshots created (#5288) #5298
ebs br: resume gc and scheduler when volume snapshots created (#5288) #5298
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-1.5 #5298 +/- ##
===============================================
+ Coverage 57.53% 60.24% +2.70%
===============================================
Files 251 258 +7
Lines 30210 34238 +4028
===============================================
+ Hits 17382 20626 +3244
- Misses 11122 11749 +627
- Partials 1706 1863 +157
|
/retest |
This is an automated cherry-pick of #5288
What problem does this PR solve?
resume gc and pd scheduler when all the volume snapshots are created
Closes ebs br: shrink the window of pause gc and schedule during backup #5256
send
SIGTERM
to the BR process when tidb-backup-manager receivesSIGTERM
read stderr async in case that the pipe of stderr is full and blocks the BR process
Closes backup job is stuck(snapshot is completed) #5281
The EBS backup task may cause the import task to fail
Closes The EBS backup task may cause the import task to fail #5282
What is changed and how does it work?
data plane:
backupmeta
file is existed when the backup enterexecute
phase. if it is existed, modify backup statusVolumeBackupSnapshotsCreated
control plane:
2. if all the backups in data plane has status
VolumeBackupSnapshotsCreated
, modifyresumeGcSchedule
fieldtrue
in the backup that is responsible to pause gc and pd schduler.data plane:
3. if
resumeGcSchedule
field istrue
, delete the initialize pod and modify backup statusVolumeBackupInitializeComplete
control plane:
5. if the backup with
resumeGcSchedule: true
has statusVolumeBackupInitializeComplete
, modify volume backup statusSnapshotsCreated
. It means all the volume snapshots are created and gc and pd schedulers are resumed.Code changes
Tests
Side effects
Related changes
Release Notes
Please refer to Release Notes Language Style Guide before writing the release note.