Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pdms: support pv for log #5535

Merged
merged 1 commit into from
Feb 4, 2024
Merged

Conversation

HuSharp
Copy link
Contributor

@HuSharp HuSharp commented Jan 31, 2024

What problem does this PR solve?

ref tikv/pd#7519

What is changed and how does it work?

yaml like

  pdms:
    - name: "tso"
      baseImage: pingcap/pd
      version: nightly
      replicas: 2
      requests:
        storage: 1Gi
      storageVolumes:
        - name: log
          storageClassName: standard
          storageSize: 1Gi
          mountPath: /var/lib/pd/tso
      config:
        log:
          file: 
            filename: "/var/lib/pd/tso/tso.log"
    - name: "scheduling"
      baseImage: pingcap/pd
      version: nightly
      replicas: 1

will get

$ kubectl describe pod basic-pdms-tso-0 -n tidb
...
Volumes:
  pdms-tso:
    Type:       PersistentVolumeClaim (a reference to a PersistentVolumeClaim in the same namespace)
    ClaimName:  pdms-tso-basic-pdms-tso-0
    ReadOnly:   false
  pdms-tso-log:
    Type:       PersistentVolumeClaim (a reference to a PersistentVolumeClaim in the same namespace)
    ClaimName:  pdms-tso-log-basic-pdms-tso-0
    ReadOnly:   false
...

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


@ti-chi-bot ti-chi-bot bot requested a review from howardlau1999 January 31, 2024 08:53
@ti-chi-bot ti-chi-bot bot added the size/XL label Jan 31, 2024
@HuSharp HuSharp requested review from csuzhangxc and rleungx and removed request for howardlau1999 January 31, 2024 08:54
@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2024

Codecov Report

Attention: 30 lines in your changes are missing coverage. Please review.

Comparison is base (9c48ee5) 61.38% compared to head (011da18) 67.09%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5535      +/-   ##
==========================================
+ Coverage   61.38%   67.09%   +5.71%     
==========================================
  Files         234      245      +11     
  Lines       29962    33849    +3887     
==========================================
+ Hits        18393    22712    +4319     
+ Misses       9736     9265     -471     
- Partials     1833     1872      +39     
Flag Coverage Δ
e2e 46.18% <17.50%> (?)
unittest 61.36% <24.32%> (-0.03%) ⬇️

Signed-off-by: husharp <[email protected]>
@HuSharp
Copy link
Contributor Author

HuSharp commented Feb 1, 2024

/run-all-tests

1 similar comment
@HuSharp
Copy link
Contributor Author

HuSharp commented Feb 2, 2024

/run-all-tests

@HuSharp
Copy link
Contributor Author

HuSharp commented Feb 2, 2024

/run-pull-e2e-kind

@HuSharp
Copy link
Contributor Author

HuSharp commented Feb 2, 2024

/run-pull-e2e-kind-across-kubernetes

@rleungx
Copy link
Member

rleungx commented Feb 2, 2024

/run-pull-e2e-kind

@ti-chi-bot ti-chi-bot bot added the lgtm label Feb 4, 2024
Copy link
Contributor

ti-chi-bot bot commented Feb 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csuzhangxc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

ti-chi-bot bot commented Feb 4, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-04 03:20:39.146207591 +0000 UTC m=+67764.712977466: ☑️ agreed by csuzhangxc.

@ti-chi-bot ti-chi-bot bot added the approved label Feb 4, 2024
@ti-chi-bot ti-chi-bot bot merged commit be43867 into pingcap:master Feb 4, 2024
13 checks passed
@HuSharp HuSharp deleted the support_pdms_pvc branch February 4, 2024 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants