Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pdms: randomly run pdms in e2e test #5559

Merged
merged 7 commits into from
Mar 6, 2024
Merged

pdms: randomly run pdms in e2e test #5559

merged 7 commits into from
Mar 6, 2024

Conversation

HuSharp
Copy link
Contributor

@HuSharp HuSharp commented Feb 29, 2024 •
edited
Loading

What problem does this PR solve?

Ref tikv/pd#7519

run e2e in local machine
image

test log in ci
https://ci.pingcap.net/blue/organizations/jenkins/tidb-operator-pull-e2e-kind/detail/tidb-operator-pull-e2e-kind/5325/pipeline/65
image

What is changed and how does it work?

Tests

  • E2E test
  • Manual test

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.

@HuSharp
random run pdms in e2e
25ba435 
Signed-off-by: husharp <[email protected]>
@HuSharp HuSharp requested a review from csuzhangxc February 29, 2024 09:09
@ti-chi-bot ti-chi-bot bot requested a review from shonge February 29, 2024 09:09
@HuSharp
Copy link
Contributor Author

HuSharp commented Feb 29, 2024

/run-all-tests

@ti-chi-bot ti-chi-bot bot added the size/L label Feb 29, 2024
@HuSharp HuSharp removed the request for review from shonge February 29, 2024 09:09
@HuSharp HuSharp mentioned this pull request Feb 29, 2024
Closed
@HuSharp HuSharp changed the title pdms: random run pdms in e2e test pdms: randomly run pdms in e2e test Feb 29, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 29, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 64.51613% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 61.06%. Comparing base (f588fed) to head (b91fcd5).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5559      +/-   ##
==========================================
- Coverage   61.51%   61.06%   -0.45%     
==========================================
  Files         235      246      +11     
  Lines       30178    34053    +3875     
==========================================
+ Hits        18565    20796    +2231     
- Misses       9755    11313    +1558     
- Partials     1858     1944      +86
Flag Coverage Δ
e2e 23.48% <29.03%> (?)
unittest 61.52% <41.37%> (+0.01%) ⬆️

@ti-chi-bot ti-chi-bot bot added size/XL and removed size/L labels Mar 4, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 4, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from husharp, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@HuSharp
merge master
5185b22 
Signed-off-by: husharp <[email protected]>
@HuSharp HuSharp force-pushed the support_pdms_e2e_test branch from 9c5b606 to f84400a Compare March 4, 2024 02:53
@HuSharp
Copy link
Contributor Author

HuSharp commented Mar 4, 2024

/run-all-tests

@HuSharp
support e2e test
076d538 
Signed-off-by: husharp <[email protected]>
@HuSharp HuSharp force-pushed the support_pdms_e2e_test branch from f84400a to 076d538 Compare March 4, 2024 09:49
@HuSharp
Copy link
Contributor Author

HuSharp commented Mar 4, 2024

/run-all-tests

@HuSharp
Copy link
Contributor Author

HuSharp commented Mar 5, 2024

/run-pull-e2e-kind-tngm

HuSharp
HuSharp commented Mar 5, 2024
View reviewed changes
examples/basic/pd-micro-service-cluster.yaml
Comment on lines +20 to 22
baseImage: hub-new.pingcap.net/orchestration/pd
version: v8.0.0
maxFailoverCount: 0
Copy link
Contributor Author

@HuSharp HuSharp Mar 5, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As tikv/pd#7819 changed pdms interface, we need to update it when releasing pd 8.0.0

csuzhangxc
csuzhangxc reviewed Mar 5, 2024
View reviewed changes
pkg/manager/member/pd_member_manager.go Outdated Show resolved Hide resolved
pkg/manager/member/pd_ms_member_manager.go Outdated Show resolved Hide resolved
tests/pkg/fixture/fixture.go Outdated Show resolved Hide resolved
HuSharp added 2 commits March 5, 2024 10:57
@HuSharp
reset pdms sync order
bdb72f8 
Signed-off-by: husharp <[email protected]>
@HuSharp
address comment
e0dc65a 
Signed-off-by: husharp <[email protected]>
@HuSharp HuSharp force-pushed the support_pdms_e2e_test branch from e46bdee to e0dc65a Compare March 5, 2024 03:06
@HuSharp
Copy link
Contributor Author

HuSharp commented Mar 5, 2024

/run-all-tests

1 similar comment
@HuSharp
Copy link
Contributor Author

HuSharp commented Mar 5, 2024

/run-all-tests

@HuSharp
Copy link
Contributor Author

HuSharp commented Mar 5, 2024

/run-pull-e2e-kind-across-kubernetes

@HuSharp
Copy link
Contributor Author

HuSharp commented Mar 5, 2024

/run-pull-e2e-kind-br

@HuSharp
add ns and name in log
55f9ee4 
Signed-off-by: husharp <[email protected]>
@HuSharp
Copy link
Contributor Author

HuSharp commented Mar 5, 2024

/run-all-tests

@HuSharp
Copy link
Contributor Author

HuSharp commented Mar 5, 2024

/run-pull-e2e-kind-tngm

@HuSharp
Copy link
Contributor Author

HuSharp commented Mar 5, 2024

/run-all-tests

@ti-chi-bot ti-chi-bot bot added size/XXL and removed size/XL labels Mar 5, 2024
@HuSharp
Copy link
Contributor Author

HuSharp commented Mar 5, 2024

/run-all-tests

@HuSharp HuSharp force-pushed the support_pdms_e2e_test branch from b91fcd5 to 55f9ee4 Compare March 6, 2024 00:01
@ti-chi-bot ti-chi-bot bot added size/XL and removed size/XXL labels Mar 6, 2024
@HuSharp
Copy link
Contributor Author

HuSharp commented Mar 6, 2024

/run-all-tests

4 similar comments
@HuSharp
Copy link
Contributor Author

HuSharp commented Mar 6, 2024

/run-all-tests

@HuSharp
Copy link
Contributor Author

HuSharp commented Mar 6, 2024

/run-all-tests

@HuSharp
Copy link
Contributor Author

HuSharp commented Mar 6, 2024

/run-all-tests

@HuSharp
Copy link
Contributor Author

HuSharp commented Mar 6, 2024

/run-all-tests

@HuSharp
Copy link
Contributor Author

HuSharp commented Mar 6, 2024

/run-pull-e2e-kind-br

@HuSharp
Copy link
Contributor Author

HuSharp commented Mar 6, 2024

/run-pull-e2e-kind-tikv-scale-simultaneously

@HuSharp
Copy link
Contributor Author

HuSharp commented Mar 6, 2024

/run-pull-e2e-kind-br

@HuSharp
Copy link
Contributor Author

HuSharp commented Mar 6, 2024

/run-pull-e2e-kind-tikv-scale-simultaneously

@HuSharp
Copy link
Contributor Author

HuSharp commented Mar 6, 2024

/run-pull-e2e-kind-br

@HuSharp
Copy link
Contributor Author

HuSharp commented Mar 6, 2024

/run-pull-e2e-kind-tikv-scale-simultaneously

@csuzhangxc csuzhangxc merged commit 4d45e49 into pingcap:master Mar 6, 2024
16 of 17 checks passed
@HuSharp HuSharp deleted the support_pdms_e2e_test branch March 6, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csuzhangxc csuzhangxc csuzhangxc left review comments

Assignees
No one assigned
Labels
size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HuSharp @codecov-commenter @csuzhangxc