Skip to content

Commit

Permalink
schemaStorage(ticdc): unify 2 schema storage implementation (#10327)
Browse files Browse the repository at this point in the history
close #10332
  • Loading branch information
3AceShowHand authored Dec 25, 2023
1 parent 8b42cb0 commit 40cd9c8
Show file tree
Hide file tree
Showing 16 changed files with 340 additions and 417 deletions.
10 changes: 5 additions & 5 deletions cdc/entry/mounter_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
Expand Down Expand Up @@ -1038,7 +1038,7 @@ func TestE2ERowLevelChecksum(t *testing.T) {
require.NoError(t, err)

changefeed := model.DefaultChangeFeedID("changefeed-test-decode-row")
schemaStorage, err := NewSchemaStorage(helper.GetCurrentMeta(),
schemaStorage, err := NewSchemaStorage(helper.Storage(),
ver.Ver, false, changefeed, util.RoleTester, filter)
require.NoError(t, err)
require.NotNil(t, schemaStorage)
Expand Down Expand Up @@ -1210,7 +1210,7 @@ func TestDecodeRowEnableChecksum(t *testing.T) {
require.NoError(t, err)

changefeed := model.DefaultChangeFeedID("changefeed-test-decode-row")
schemaStorage, err := NewSchemaStorage(helper.GetCurrentMeta(),
schemaStorage, err := NewSchemaStorage(helper.Storage(),
ver.Ver, false, changefeed, util.RoleTester, filter)
require.NoError(t, err)
require.NotNil(t, schemaStorage)
Expand Down Expand Up @@ -1339,7 +1339,7 @@ func TestDecodeRow(t *testing.T) {
filter, err := filter.NewFilter(cfg, "")
require.NoError(t, err)

schemaStorage, err := NewSchemaStorage(helper.GetCurrentMeta(),
schemaStorage, err := NewSchemaStorage(helper.Storage(),
ver.Ver, false, changefeed, util.RoleTester, filter)
require.NoError(t, err)

Expand Down Expand Up @@ -1420,7 +1420,7 @@ func TestDecodeEventIgnoreRow(t *testing.T) {
ver, err := helper.Storage().CurrentVersion(oracle.GlobalTxnScope)
require.Nil(t, err)

schemaStorage, err := NewSchemaStorage(helper.GetCurrentMeta(),
schemaStorage, err := NewSchemaStorage(helper.Storage(),
ver.Ver, false, cfID, util.RoleTester, f)
require.Nil(t, err)
// apply ddl to schemaStorage
Expand Down
Loading

0 comments on commit 40cd9c8

Please sign in to comment.