Skip to content

Commit

Permalink
checker(dm): Replace URL in error (#10211)
Browse files Browse the repository at this point in the history
close #10210
  • Loading branch information
dveeden authored Dec 8, 2023
1 parent bfc1e00 commit ac57268
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions dm/pkg/checker/binlog.go
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ func (pc *MySQLBinlogFormatChecker) Check(ctx context.Context) *Result {
}
if strings.ToUpper(value) != "ROW" {
result.Errors = append(result.Errors, NewError("binlog_format is %s, and should be ROW", value))
result.Instruction = "MySQL as source: please execute 'set global binlog_format=ROW;'; AWS Aurora (MySQL)/RDS MySQL as source: please refer to the document to create a new DB parameter group and set the binlog_format=row: https://docs.aws.amazon.com/zh_cn/AmazonRDS/latest/AuroraUserGuide/USER_WorkingWithDBInstanceParamGroups.html. Then modify the instance to use the new DB parameter group and restart the instance to take effect."
result.Instruction = "MySQL as source: please execute 'set global binlog_format=ROW;'; AWS Aurora (MySQL)/RDS MySQL as source: please refer to the document to create a new DB parameter group and set the binlog_format=row: https://docs.aws.amazon.com/AmazonRDS/latest/AuroraUserGuide/USER_WorkingWithDBInstanceParamGroups.html. Then modify the instance to use the new DB parameter group and restart the instance to take effect."
return result
}
result.State = StateSuccess
Expand Down Expand Up @@ -183,7 +183,7 @@ func (pc *MySQLBinlogRowImageChecker) Check(ctx context.Context) *Result {
}
if strings.ToUpper(value) != "FULL" {
result.Errors = append(result.Errors, NewError("binlog_row_image is %s, and should be FULL", value))
result.Instruction = "MySQL as source: please execute 'set global binlog_row_image = FULL;'; AWS Aurora (MySQL)/RDS MySQL as source: please refer to the document to create a new DB parameter group and set the binlog_row_image = FULL: https://docs.aws.amazon.com/zh_cn/AmazonRDS/latest/AuroraUserGuide/USER_WorkingWithDBInstanceParamGroups.html Then modify the instance to use the new DB parameter group and restart the instance to take effect."
result.Instruction = "MySQL as source: please execute 'set global binlog_row_image = FULL;'; AWS Aurora (MySQL)/RDS MySQL as source: please refer to the document to create a new DB parameter group and set the binlog_row_image = FULL: https://docs.aws.amazon.com/AmazonRDS/latest/AuroraUserGuide/USER_WorkingWithDBInstanceParamGroups.html Then modify the instance to use the new DB parameter group and restart the instance to take effect."
return result
}
result.State = StateSuccess
Expand Down

0 comments on commit ac57268

Please sign in to comment.