Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

redo(ticdc): add meta flush interval configuration (#9959) (#9971) #10000

Merged
merged 3 commits into from
Nov 3, 2023
Merged

redo(ticdc): add meta flush interval configuration (#9959) (#9971) #10000

merged 3 commits into from
Nov 3, 2023

Conversation

sdojjy
Copy link
Member

@sdojjy sdojjy commented Nov 2, 2023

This is an automated cherry-pick of #9959

What problem does this PR solve?

Issue Number: close #9960

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

`Add meta-flush-interval configuration to facilitate redo module tuning`.

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 2, 2023
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 3, 2023
@sdojjy
Copy link
Member Author

sdojjy commented Nov 3, 2023

/retest-required

@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 3, 2023
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 3, 2023
@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 3, 2023
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asddongmen, nongfushanquan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 3, 2023
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 3, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-03 13:21:32.276735512 +0000 UTC m=+3218489.863845655: ☑️ agreed by nongfushanquan.
  • 2023-11-03 14:09:27.464474702 +0000 UTC m=+3221365.051584832: ☑️ agreed by asddongmen.

@ti-chi-bot ti-chi-bot bot merged commit 1b62946 into pingcap:release-6.5-20230923-v6.5.5 Nov 3, 2023
3 checks passed
@sdojjy sdojjy deleted the hotfix-for-hzbank branch November 4, 2023 00:35
@sdojjy sdojjy restored the hotfix-for-hzbank branch November 7, 2023 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nongfushanquan nongfushanquan nongfushanquan approved these changes

@asddongmen asddongmen asddongmen approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sdojjy @asddongmen @nongfushanquan @ti-chi-bot