ddlManager (ticdc): add bootstrap sending function #10045
Conversation
ti-chi-bot
bot
added
release-note
ti-chi-bot
bot
added
size/L
cdc/owner/ddl_manager.go
Outdated
| m.errCh <- err | ||
| return | ||
| } | ||
| atomic.StoreInt32(&m.bootstrapState, int32(bootstrapStateCompleted)) |
There was a problem hiding this comment.
When the bootstrap state should be completed?
For one bootstrap event is sent or all the bootstrap events are sent ?
There was a problem hiding this comment.
Shall we move L668 outside of the loop ?
There was a problem hiding this comment.
The bootstrapStateCompleted will be set after all bootstrap events are sent.
There was a problem hiding this comment.
It looks it's set after the first one bootstrap event is sent at the moment.
Co-authored-by: Ling Jin <[email protected]>
…_bootstrap_function
|
/retest |
| @@ -184,6 +198,18 @@ func (m *ddlManager) tick( | |||
| checkpointTs model.Ts, | |||
| tableCheckpoint map[model.TableName]model.Ts, | |||
| ) ([]model.TableID, *schedulepb.BarrierWithMinTs, error) { | |||
| // needBootstrap is true when the downstream is kafka | |||
| // and the protocol is simple protocol. | |||
There was a problem hiding this comment.
I think this comment is redundant.
You can move it to the declaration of the needBootstrap variable
There was a problem hiding this comment.
After next PR merged, it will be remove.
ti-chi-bot
bot
added
needs-1-more-lgtm
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 3AceShowHand, CharlesCheung96 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
|
/retest |
What problem does this PR solve?
Issue Number: ref #9898 close #10107
What is changed and how it works?
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note