Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mereics(ticdc): add cdc_resolvedts_high_delay alert #10078

Merged
merged 2 commits into from
Nov 23, 2023
Merged

mereics(ticdc): add cdc_resolvedts_high_delay alert #10078

merged 2 commits into from
Nov 23, 2023

Conversation

CharlesCheung96
Copy link
Contributor

@CharlesCheung96 CharlesCheung96 commented Nov 10, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #10113

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

If you don't think this PR needs a release note then fill it with `None`.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 10, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 10, 2023
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 15, 2023
@CharlesCheung96 CharlesCheung96 marked this pull request as ready for review November 20, 2023 08:52
@ti-chi-bot ti-chi-bot bot removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/needs-linked-issue labels Nov 20, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 20, 2023
@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 22, 2023
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand, asddongmen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [3AceShowHand,asddongmen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 22, 2023
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 22, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-20 09:41:33.291058288 +0000 UTC m=+224521.956284467: ☑️ agreed by asddongmen.
  • 2023-11-22 05:50:23.038036173 +0000 UTC m=+383451.703262377: ☑️ agreed by 3AceShowHand.

@CharlesCheung96
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit 9366da7 into pingcap:master Nov 23, 2023
14 checks passed
@CharlesCheung96 CharlesCheung96 added type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. and removed type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Dec 14, 2023
@CharlesCheung96 CharlesCheung96 added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Dec 14, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #10303.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 14, 2023
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #10304.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Dec 14, 2023
@CharlesCheung96 @ti-chi-bot
This is an automated cherry-pick of pingcap#10078
707dde6 
Signed-off-by: ti-chi-bot <[email protected]>
This was referenced Dec 14, 2023
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #10305.

CharlesCheung96 added a commit to ti-chi-bot/tiflow that referenced this pull request Dec 19, 2023
@CharlesCheung96
mereics(ticdc): add cdc_resolvedts_high_delay alert (pingcap#10078)
fb01483 
close pingcap#10113
ti-chi-bot bot pushed a commit that referenced this pull request Dec 20, 2023
@ti-chi-bot
mereics(ticdc): add cdc_resolvedts_high_delay alert (#10078) (#10304)
a99a994 
close #10113
ti-chi-bot bot pushed a commit that referenced this pull request Feb 8, 2024
@ti-chi-bot
mereics(ticdc): add cdc_resolvedts_high_delay alert (#10078) (#10305)
a385de6 
close #10113
ti-chi-bot bot pushed a commit that referenced this pull request Feb 26, 2024
@ti-chi-bot
mereics(ticdc): add cdc_resolvedts_high_delay alert (#10078) (#10303)
e83d6f8 
close #10113
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asddongmen asddongmen asddongmen approved these changes

@3AceShowHand 3AceShowHand 3AceShowHand approved these changes

Assignees
No one assigned
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add cdc_resolvedts_high_delay alert
4 participants
@CharlesCheung96 @ti-chi-bot @3AceShowHand @asddongmen