-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makefile(ticdc): support build cdc in fips mode (#9961) #10131
Makefile(ticdc): support build cdc in fips mode (#9961) #10131
Conversation
Signed-off-by: ti-chi-bot <[email protected]>
/cherry-pick-invite |
1 similar comment
/cherry-pick-invite |
@wuhuizuo Please accept the invitation then you can push to the cherry-pick pull requests. |
/cherry-pick-invite |
@purelind Please accept the invitation then you can push to the cherry-pick pull requests. |
/cherry-pick-invite |
@lidezhu Please accept the invitation then you can push to the cherry-pick pull requests. |
/retest |
/hold |
/unhold |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sdojjy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test verify |
/test verify |
2 similar comments
/test verify |
/test verify |
@ti-chi-bot: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/verify |
/test verify |
@overvenus: The specified target(s) for
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ec9ddbe
into
pingcap:feature/release-6.5-fips
This is an automated cherry-pick of #9961
What problem does this PR solve?
Issue Number: close #9962
What is changed and how it works?
-fips
in the release version of FIPS-ready binary-fips
suffix when do version checkCheck List
Tests
Make sure the version sanitize process works with
-fips
suffix;Check the boringcrypto linked via cgo, some function names like:
Questions
Will it cause performance regression or break compatibility?
The original binary should not be affected. But the binary build with FIPS support is expected to be slower.
Do you need to update user documentation, design documentation or monitoring documentation?
Need to add contents about the support for FIPS-ready binary and how to download it later;
Release note