Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sink(cdc): always handle sink failures for cases with sync-point enabled (#10132) #10142

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #10132

What problem does this PR solve?

Issue Number: close #10091

What is changed and how it works?

In SinkManager, suppose there is a table with checkpointTs=100 and lastWrittenPos=110, and sync-point is also 110.

And then, the sink backend fails, the sink should be re-started at 100.

However, when generating sink tasks, SinkManager finds the table has no more available events after lastWrittenPos=110, and it can't detect the sink backend failure any more.

With the PR this behavior is corrected.

Check List

Tests

  • Unit test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

Signed-off-by: qupeng <[email protected]>
Signed-off-by: qupeng <[email protected]>
Signed-off-by: qupeng <[email protected]>
@ti-chi-bot ti-chi-bot added lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Nov 23, 2023
Copy link
Contributor

ti-chi-bot bot commented Dec 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hicqu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 4, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Dec 4, 2023
@hicqu
Copy link
Contributor

hicqu commented Dec 4, 2023

/retest

1 similar comment
@hicqu
Copy link
Contributor

hicqu commented Dec 4, 2023

/retest

Copy link
Contributor

ti-chi-bot bot commented Dec 4, 2023

@ti-chi-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
jenkins-ticdc/verify 6ce7397 link unknown /test verify

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hicqu
Copy link
Contributor

hicqu commented Dec 4, 2023

/retest

@hicqu hicqu merged commit 011f81a into pingcap:release-7.5 Dec 4, 2023
12 of 13 checks passed
@hicqu hicqu deleted the cherry-pick-10132-to-release-7.5 branch December 4, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants