-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sink(cdc): always handle sink failures for cases with sync-point enabled (#10132) #10142
sink(cdc): always handle sink failures for cases with sync-point enabled (#10132) #10142
Conversation
Signed-off-by: qupeng <[email protected]>
Signed-off-by: qupeng <[email protected]>
Signed-off-by: qupeng <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hicqu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
1 similar comment
/retest |
@ti-chi-bot: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest |
This is an automated cherry-pick of #10132
What problem does this PR solve?
Issue Number: close #10091
What is changed and how it works?
In
SinkManager
, suppose there is a table withcheckpointTs=100
andlastWrittenPos=110
, and sync-point is also110
.And then, the sink backend fails, the sink should be re-started at
100
.However, when generating sink tasks,
SinkManager
finds the table has no more available events afterlastWrittenPos=110
, and it can't detect the sink backend failure any more.With the PR this behavior is corrected.
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note